Hey JL, did you check these names are valid? Think the - can be an issue (jdk.internal.module.Checks#requireModuleName)
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> ---------- Forwarded message --------- From: <jlmonte...@apache.org> Date: jeu. 15 nov. 2018 à 11:32 Subject: tomee git commit: TOMEE-2277 Java 11 - define modules for TomEE At the moment, they are tight to maven artifact but we can improve later. To: <comm...@tomee.apache.org> Repository: tomee Updated Branches: refs/heads/master b470fc8ce -> 127207255 TOMEE-2277 Java 11 - define modules for TomEE At the moment, they are tight to maven artifact but we can improve later. Project: http://git-wip-us.apache.org/repos/asf/tomee/repo Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/12720725 Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/12720725 Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/12720725 Branch: refs/heads/master Commit: 12720725544cd731f7192d7d9d4483974c62ac06 Parents: b470fc8 Author: Jean-Louis Monteiro <jeano...@gmail.com> Authored: Thu Nov 15 11:32:12 2018 +0100 Committer: Jean-Louis Monteiro <jeano...@gmail.com> Committed: Thu Nov 15 11:32:12 2018 +0100 ---------------------------------------------------------------------- container/openejb-core/pom.xml | 3 ++- container/openejb-javaagent/pom.xml | 3 ++- itests/openejb-itests-client/pom.xml | 5 ++++- pom.xml | 8 +++++++- server/openejb-client/pom.xml | 5 ++++- tomee/apache-tomee/pom.xml | 5 +++++ tomee/tomee-embedded/pom.xml | 5 ++++- tomee/tomee-webapp/pom.xml | 5 +++++ 8 files changed, 33 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/container/openejb-core/pom.xml ---------------------------------------------------------------------- diff --git a/container/openejb-core/pom.xml b/container/openejb-core/pom.xml index bcd6dd6..7aadde4 100644 --- a/container/openejb-core/pom.xml +++ b/container/openejb-core/pom.xml @@ -392,12 +392,13 @@ <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-jar-plugin</artifactId> <configuration> - <archive> + <archive combine.children="append"> <manifest> <mainClass>org.apache.openejb.cli.Bootstrap</mainClass> <!--<addClasspath>true</addClasspath>--> </manifest> <manifestEntries> + <Automatic-Module-Name>${tomee.build.name }</Automatic-Module-Name> <Class-Path>openejb-loader-${project.version}.jar openejb-client-${project.version}.jar xbean-finder-shaded-${xbeanVersion}.jar xbean-asm7-shaded-${xbeanVersion}.jar </Class-Path> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/container/openejb-javaagent/pom.xml ---------------------------------------------------------------------- diff --git a/container/openejb-javaagent/pom.xml b/container/openejb-javaagent/pom.xml index 5e69a63..4405551 100644 --- a/container/openejb-javaagent/pom.xml +++ b/container/openejb-javaagent/pom.xml @@ -32,8 +32,9 @@ <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-jar-plugin</artifactId> <configuration> - <archive> + <archive combine.children="append"> <manifestEntries> + <Automatic-Module-Name>${tomee.build.name }</Automatic-Module-Name> <Premain-Class>org.apache.openejb.javaagent.Agent</Premain-Class> <Agent-Class>org.apache.openejb.javaagent.Agent</Agent-Class> <Can-Redefine-Classes>true</Can-Redefine-Classes> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/itests/openejb-itests-client/pom.xml ---------------------------------------------------------------------- diff --git a/itests/openejb-itests-client/pom.xml b/itests/openejb-itests-client/pom.xml index 626a74d..fe3b24b 100644 --- a/itests/openejb-itests-client/pom.xml +++ b/itests/openejb-itests-client/pom.xml @@ -45,11 +45,14 @@ <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-jar-plugin</artifactId> <configuration> - <archive> + <archive combine.children="append"> <manifest> <mainClass>org.apache.openejb.test.Main</mainClass> <addClasspath>true</addClasspath> </manifest> + <manifestEntries> + <Automatic-Module-Name>${tomee.build.name }</Automatic-Module-Name> + </manifestEntries> </archive> </configuration> </plugin> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index 537ec3a..404521e 100644 --- a/pom.xml +++ b/pom.xml @@ -99,6 +99,9 @@ <maven.compiler.target>1.8</maven.compiler.target> <surefire.version>2.21.0</surefire.version> + <!-- for the default name of the module --> + <tomee.build.name>${project.groupId}.${project.artifactId}</ tomee.build.name> + <!-- To easily change the javaee api version --> <version.javaee-api>8.0</version.javaee-api> @@ -455,8 +458,11 @@ <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-jar-plugin</artifactId> <configuration> - <archive> + <archive combine.children="append"> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile> + <manifestEntries> + <Automatic-Module-Name>${tomee.build.name }</Automatic-Module-Name> + </manifestEntries> </archive> </configuration> </plugin> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/server/openejb-client/pom.xml ---------------------------------------------------------------------- diff --git a/server/openejb-client/pom.xml b/server/openejb-client/pom.xml index c40d60c..5618ec4 100644 --- a/server/openejb-client/pom.xml +++ b/server/openejb-client/pom.xml @@ -80,10 +80,13 @@ <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-jar-plugin</artifactId> <configuration> - <archive> + <archive combine.children="append"> <manifest> <mainClass>org.apache.openejb.client.Main</mainClass> </manifest> + <manifestEntries> + <Automatic-Module-Name>${tomee.build.name }</Automatic-Module-Name> + </manifestEntries> </archive> </configuration> </plugin> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/tomee/apache-tomee/pom.xml ---------------------------------------------------------------------- diff --git a/tomee/apache-tomee/pom.xml b/tomee/apache-tomee/pom.xml index 574c562..d02a785 100644 --- a/tomee/apache-tomee/pom.xml +++ b/tomee/apache-tomee/pom.xml @@ -140,6 +140,11 @@ <include>**/RemoteTomEEEJBContainer*.class</include> <include>**/META-INF/services/javax.ejb.spi.EJBContainerProvider</include> </includes> + <archive combine.children="append"> + <manifestEntries> + <Automatic-Module-Name>${tomee.build.name }</Automatic-Module-Name> + </manifestEntries> + </archive> </configuration> </plugin> <plugin> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/tomee/tomee-embedded/pom.xml ---------------------------------------------------------------------- diff --git a/tomee/tomee-embedded/pom.xml b/tomee/tomee-embedded/pom.xml index 659fa1c..bcb6c72 100644 --- a/tomee/tomee-embedded/pom.xml +++ b/tomee/tomee-embedded/pom.xml @@ -44,11 +44,14 @@ <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-jar-plugin</artifactId> <configuration> - <archive> + <archive combine.children="append"> <manifest> <Main-Class>org.apache.tomee.embedded.Main</Main-Class> <addClasspath>true</addClasspath> </manifest> + <manifestEntries> + <Automatic-Module-Name>${tomee.build.name }</Automatic-Module-Name> + </manifestEntries> </archive> </configuration> </plugin> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/tomee/tomee-webapp/pom.xml ---------------------------------------------------------------------- diff --git a/tomee/tomee-webapp/pom.xml b/tomee/tomee-webapp/pom.xml index c538123..9ba180e 100644 --- a/tomee/tomee-webapp/pom.xml +++ b/tomee/tomee-webapp/pom.xml @@ -76,6 +76,11 @@ <include>META-INF/**/*</include> <include>juli.properties</include> </includes> + <archive combine.children="append"> + <manifestEntries> + <Automatic-Module-Name>${tomee.build.name }</Automatic-Module-Name> + </manifestEntries> + </archive> </configuration> </plugin> <plugin>
