Merged.
I'll run a build locally. On a slightly different topic, I get a test
failure in mp-metrics-counted - could someone take a look? Here's the error
- it looks like a map ordering, so maybe we need to compare the individual
JSON elements here:
https://github.com/apache/tomee/blob/master/examples/mp-metrics-counted/src/test/java/org/superbiz/rest/WeatherServiceTest.java#L116
?
Cheers
Jon
[INFO] --- maven-surefire-plugin:2.21.0:test (default-test) @
mp-metrics-counted ---
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.superbiz.rest.WeatherServiceTest
Nov 28, 2018 2:45:08 PM org.apache.openejb.arquillian.common.Setup findHome
INFO: Unable to find home in:
/tmp/experimental_worker/cmp-jpa/build/examples/mp-metrics-counted/target/apache-tomee-remote
Nov 28, 2018 2:45:08 PM org.apache.openejb.arquillian.common.MavenCache
getArtifact
INFO: Downloading
org.apache.tomee:apache-tomee:8.0.0-SNAPSHOT:zip:microprofile please wait...
Nov 28, 2018 2:45:08 PM org.apache.openejb.arquillian.common.Zips unzip
INFO: Extracting
'/home/jgallimore/.m2/repository/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-SNAPSHOT-microprofile.zip'
to
'/tmp/experimental_worker/cmp-jpa/build/examples/mp-metrics-counted/target/apache-tomee-remote'
Nov 28, 2018 2:45:09 PM
org.apache.tomee.arquillian.remote.RemoteTomEEContainer configure
INFO: Downloaded container to:
/tmp/experimental_worker/cmp-jpa/build/examples/mp-metrics-counted/target/apache-tomee-remote/apache-tomee-microprofile-8.0.0-SNAPSHOT
Nov 28, 2018 2:45:10 PM org.apache.openejb.client.EventLogger log
INFO: RemoteInitialContextCreated{providerUri=
http://localhost:37497/tomee/ejb}
Nov 28, 2018 2:45:13 PM org.apache.openejb.client.EventLogger log
INFO: RemoteInitialContextCreated{providerUri=
http://localhost:37497/tomee/ejb}
Nov 28, 2018 2:45:13 PM org.apache.openejb.arquillian.common.TomEEContainer
undeploy
INFO: cleaning
/tmp/experimental_worker/cmp-jpa/build/examples/mp-metrics-counted/target/arquillian-test-working-dir/0/test.war
Nov 28, 2018 2:45:13 PM org.apache.openejb.arquillian.common.TomEEContainer
undeploy
INFO: cleaning
/tmp/experimental_worker/cmp-jpa/build/examples/mp-metrics-counted/target/arquillian-test-working-dir/0/test
[ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
4.958 s <<< FAILURE! - in org.superbiz.rest.WeatherServiceTest
[ERROR] testCountedMetricMetadata(org.superbiz.rest.WeatherServiceTest)
Time elapsed: 0.475 s <<< FAILURE!
java.lang.AssertionError:
expected:<{"weather_day_status":{"unit":"none","displayName":"Weather Day
Status","name":"weather_day_status","typeRaw":"COUNTER","description":"This
metric shows the weather status of the
day.","type":"counter","value":{"unit":"none","displayName":"Weather Day
Status","name":"weather_day_status","tagsAsString":"","typeRaw":"COUNTER","description":"This
metric shows the weather status of the
day.","type":"counter","reusable":false,"tags":{}},"reusable":false,"tags":""}}>
but was:<{"weather_day_status":{"description":"This metric shows the
weather status of the day.","displayName":"Weather Day
Status","name":"weather_day_status","reusable":false,"tags":"","type":"counter","typeRaw":"COUNTER","unit":"none"}}>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.superbiz.rest.WeatherServiceTest.testCountedMetricMetadata(WeatherServiceTest.java:116)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.jboss.arquillian.junit.Arquillian$6$1.invoke(Arquillian.java:270)
at
org.jboss.arquillian.container.test.impl.execution.LocalTestExecuter.execute(LocalTestExecuter.java:60)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:94)
at
org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:99)
at
org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:81)
at
org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:135)
at
org.jboss.arquillian.core.impl.ManagerImpl.fire(ManagerImpl.java:115)
at org.jboss.arquillian.core.impl.EventImpl.fire(EventImpl.java:67)
at
org.jboss.arquillian.container.test.impl.execution.ClientTestExecuter.execute(ClientTestExecuter.java:53)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:94)
at
org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:99)
at
org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:81)
at
org.jboss.arquillian.container.test.impl.client.ContainerEventController.createContext(ContainerEventController.java:142)
at
org.jboss.arquillian.container.test.impl.client.ContainerEventController.createTestContext(ContainerEventController.java:129)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:94)
at
org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:88)
at
org.jboss.arquillian.test.impl.TestContextHandler.createTestContext(TestContextHandler.java:89)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:94)
at
org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:88)
at
org.jboss.arquillian.test.impl.TestContextHandler.createClassContext(TestContextHandler.java:75)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:94)
at
org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:88)
at
org.jboss.arquillian.test.impl.TestContextHandler.createSuiteContext(TestContextHandler.java:60)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
On Wed, Nov 28, 2018 at 7:59 PM Ivan Junckes Filho <ivanjunc...@gmail.com>
wrote:
> Hey guys, any commiter could help merging this?
>
> It is already appoved.
>
> On Tue, Nov 27, 2018 at 2:07 PM Ivan Junckes Filho <ivanjunc...@gmail.com>
> wrote:
>
> > Hey guys, this PR has the goal to provide a @Timed example using
> > Microprofile Metrics in TomEE8, could you please review and merge?
> >
> > https://github.com/apache/tomee/pull/218
> >
> > Btw, Romain and Bruno already did a review and I addressed their
> > suggestions.
> >
>
