Bruno, there is a conflict in the PR. On Thu, Nov 29, 2018 at 9:49 AM Bruno Baptista <bruno...@gmail.com> wrote:
> Hi, > > Can some committer please decide if this is good to merge? > > https://github.com/apache/tomee/pull/214 > > Thanks > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 26/11/18 17:58, Bruno Baptista wrote: > > Hi Romain, > > > > Thanks for you feedback. > > > > I've pushed changes and added a comment to the PR. > > > > Cheers. > > > > Bruno Baptista > > https://twitter.com/brunobat_ > > > > > > On 26/11/18 17:11, Romain Manni-Bucau wrote: > >> Hello Bruno, > >> > >> I put some suggestions on the PR, hope it helps. > >> > >> Romain Manni-Bucau > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> <https://rmannibucau.metawerx.net/> | Old Blog > >> <http://rmannibucau.wordpress.com> | Github > >> <https://github.com/rmannibucau> | > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > >> < > https://www.packtpub.com/application-development/java-ee-8-high-performance> > > >> > >> > >> > >> Le lun. 26 nov. 2018 à 18:02, Bruno Baptista <bruno...@gmail.com> a > >> écrit : > >> > >>> Hi, > >>> > >>> I think the code for this example: TOMEE-2283 New Example: Websocket > >>> with TLS and Basic Auth > >>> <https://issues.apache.org/jira/browse/TOMEE-2283> > >>> > >>> Is ready for review here: https://github.com/apache/tomee/pull/214 > >>> > >>> Can one of you please take a look? > >>> > >>> Cheers > >>> > >>> -- > >>> Bruno Baptista > >>> https://twitter.com/brunobat_ > >>> > >>> > >>> >
