Hi José,
Yes, there is work in progress to update Safeguard to Fault Tolerance
1.1 compliance.
I'm looking forward to review your PR.
Cheers.
Bruno Baptista
https://twitter.com/brunobat_
On 05/12/18 16:30, Jose Henrique Ventura wrote:
Hi Bruno,
Thanks for the feedback.
I have submitted my PR, finally.
Do you know if there is a plan for implementing that feature in
Geronimo-Safeguard project?
I would love to help. =)
Best Regards,
José Henrique Ventura.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Tuesday, December 4, 2018 9:29 AM, Bruno Baptista <bruno...@gmail.com> wrote:
Hi José,
The Metrics integration with the @Retry and the Fault Tolerance spec in
general was only added in FT v1.1. This has not yet been implemented in
the Geronimo-Safeguard library we are using for Fault Tolerance. That's
why you don't find it.
I've taken a look at your example and, so far, it looks fine to me.
Just one thing. The @Retry might happen in case of any exception. You
can, in one of the examples, throw a RuntimeException and show that the
retry will happen nevertheless.
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 03/12/18 21:51, Jose Henrique Ventura wrote:
Hi Guys,
I still have a few things to change/write in the README.md file before I send
PR but looking at microprofile-fault-tolerance spec, I see Metrics added for
@Retry and looking at the geronimo codebase I did not find anything related
with retry there or maybe I'm looking at the wrong place.
So, Could someone advise me if that part of the spec was implemented, please?
and if so, let me know it if would be good to add a test case related to
Metrics in this example?
https://github.com/josehenriqueventura/tomee/tree/mp-faulttolerance-retry/examples/mp-faulttolerance-retry
(feel free to provide any feedback for what I have done so far.)
Best Regards,
José Henrique Ventura.
