Pulling and building it now :). Thanks Dani! On Mon, Dec 10, 2018 at 2:23 PM Daniel Cunha <daniels...@gmail.com> wrote:
> Nice! > > PR opened: https://github.com/apache/tomee/pull/267 > > Em seg, 10 de dez de 2018 às 11:01, Jonathan Gallimore < > jonathan.gallim...@gmail.com> escreveu: > > > Awesome, SNAPSHOT is good. Send a PR :) > > > > > > On Mon, Dec 10, 2018 at 1:45 PM Daniel Cunha <daniels...@apache.org> > > wrote: > > > > > Hi folks, > > > > > > The fix for testes below is already on bval master branch. > > > Just update bval to 2.0.1-SNAPSHOT and it will be fixed. > > > > > > DuplicateConfigurationTest > > > XMLConfigurationTest > > > XMLConfiguredConstraintValidatorTest > > > > > > Can we use SNAPSHOT for now or wait for the next bval release? > > > > > > > > > Em dom, 9 de dez de 2018 às 20:23, Roberto Cortez > > > <radcor...@yahoo.com.invalid> escreveu: > > > > > > > Agree on both. > > > > > > > > > On 9 Dec 2018, at 07:52, Jean-Louis Monteiro < > > jlmonte...@tomitribe.com > > > > > > > > wrote: > > > > > > > > > > I only fixed the 2 imports for checkstyle > > > > > > > > > > I don't think from an end user perspective the information is very > > > > > important in the changelog so did not created any ticket. > > > > > > > > > > If everyone thinks this is important for the user. I'm happy to > > create > > > > one. > > > > > > > > > > In that area I don't think it makes sense either to create a bug in > > > Jira > > > > > for a non released feature. So if there is a new example and you > > find a > > > > > bug. Go ahead and fix it. No need to create a new ticket. Use the > one > > > > > mentioning we are creating a new example. > > > > > > > > > > > > > > > > > > > > Le sam. 8 déc. 2018 à 19:30, Frankie <kamin.feuer.2...@gmx.de> a > > > écrit : > > > > > > > > > >> Overlooked that, sorry. > > > > >> I intended to concentrate on the documentation for contribution > > > > workflow, > > > > >> that's why I asked. > > > > >> So no problem if Jean-Louis picks it up. > > > > >> And: what about a JIRA ticket for that ... ? ;-) > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> -- > > > > >> Sent from: > > > > >> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html > > > > >> > > > > > > > > > > > > > > -- > > > Daniel "soro" Cunha > > > https://twitter.com/dvlc_ > > > > > > > > -- > Daniel "soro" Cunha > https://twitter.com/dvlc_ >
