Great! Interesting. If things are missing, then they are not being picked up by the TCK.
So I think we need to checkout the MP Metrics TCK and see if they are checking for these metrics and possible open an issue for them and a PR. Also, open an issue on the Geronimo project, since the Metrics implementation comes from Geronimo. Here are the links: https://github.com/eclipse/microprofile-metrics <https://github.com/eclipse/microprofile-metrics> https://issues.apache.org/jira/projects/GERONIMO/ <https://issues.apache.org/jira/projects/GERONIMO/> Would you like to do it Francois? Cheers, Roberto > On 4 Jan 2019, at 16:05, COURTAULT Francois <francois.courta...@gemalto.com> > wrote: > > Hello Roberto, > > Yes I have run one of your example and now I am able to see some of the > Required Metrics. > > The list below is missing in the metrics report (eg some Required Metrics are > missing): > - Thread Pool Stats > * threadPool.%s.activeThreads > * threadPool.%s.size > - Operating System : > * cpu.systemLoadAverage > * cpu.processCpuLoad > > Should I submit a JIRA issue for that ? > > Best Regards. > > -----Original Message----- > From: Roberto Cortez [mailto:radcor...@yahoo.com.INVALID > <mailto:radcor...@yahoo.com.INVALID>] > Sent: vendredi 4 janvier 2019 12:17 > To: us...@tomee.apache.org <mailto:us...@tomee.apache.org> > Cc: dev@tomee.apache.org <mailto:dev@tomee.apache.org> > Subject: Re: TomEE 7.1 release note issue ? and Metrics not working on TomEE > 8.0.0 M1 ? > > Hi Francois, > > The metrics are exposed when you deploy an app, so you need to have an app > deployed and then the metrics should be available in > http://localhost:8080/APP_CONTEXT/metrics > <http://localhost:8080/APP_CONTEXT/metrics> > > Are you running TomEE with the MicroProfile classifier? > > Have you tried any of the samples that I’ve sent you? > > Cheers, > Roberto > >> On 4 Jan 2019, at 09:33, COURTAULT Francois <francois.courta...@gemalto.com> >> wrote: >> >> Hello Roberto, >> >> Regarding TomEE 8 metrics issue, according to the MP-Metrics spec (§2.1.1), >> the Metrics MP provider has to implement some required metrics described in >> Chapiter 4. Required Metrics. >> >> My question is how to get those with TomEE 8.0.0 M1 ? which URL I have >> to invoke ? I have tried several like localhost:8080/metrics/base, >> localhost:8080/metrics, localhost:8080/rest-mp-metrics, >> localhost:8080/mp-metrics, localhost:8080/mp-metrics/base, , >> localhost:8080/mp-metrics-base but all of those return 404 :-( >> >> Best Regards. >> >> -----Original Message----- >> From: Roberto Cortez [mailto:radcor...@yahoo.com.INVALID] >> Sent: jeudi 3 janvier 2019 20:01 >> To: us...@tomee.apache.org >> Cc: dev@tomee.apache.org >> Subject: Re: TomEE 7.1 release note issue ? and Metrics not working on TomEE >> 8.0.0 M1 ? >> Importance: High >> >> Hi Francois, >> >> You are right. Geronimo Metrics 1.0.0 implementation, unfortunately is not >> compatible with TomEE 7 due to CDI 2.0 requirement. >> >> The release notes are somehow misleading. We had the task there to add it, >> and we tried until we found the issue, so the issue was resolved as >> Incomplete. We probably need to adjust the template to not include these. >> >> Regarding TomEE 8, they should work. Did you have a look in any of the >> samples? >> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >> hub.com%2Fapache%2Ftomee%2Ftree%2Fmaster%2Fexamples%2Fmp-metrics-count >> ed&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com >> <http://40gemalto.com/>%7Cd28c5c4ecb2e4 >> 894702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C63682 >> 1974227610792&sdata=yZflkA5LEbMlgbwqK6Inc%2BgFR%2FeijqKJoELBkFzMaP >> A%3D&reserved=0 >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi> >> thub.com >> <http://thub.com/>%2Fapache%2Ftomee%2Ftree%2Fmaster%2Fexamples%2Fmp-metrics-coun >> ted&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com >> <http://40gemalto.com/>%7Cd28c5c4ecb2e >> 4894702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C6368 >> 21974227610792&sdata=yZflkA5LEbMlgbwqK6Inc%2BgFR%2FeijqKJoELBkFzMa >> PA%3D&reserved=0> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit> >> hub.com >> <http://hub.com/>%2Fapache%2Ftomee%2Ftree%2Fmaster%2Fexamples%2Fmp-metrics-histo >> gram&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com >> <http://40gemalto.com/>%7Cd28c5c4ecb2 >> e4894702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C636 >> 821974227610792&sdata=CwlKb9iphtr9BtGkb%2B3nM72Ed3ZLBOL9FT4z1wnB9g >> 4%3D&reserved=0 >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi> >> thub.com >> <http://thub.com/>%2Fapache%2Ftomee%2Ftree%2Fmaster%2Fexamples%2Fmp-metrics-hist >> ogram&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com >> <http://40gemalto.com/>%7Cd28c5c4ecb >> 2e4894702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C63 >> 6821974227610792&sdata=CwlKb9iphtr9BtGkb%2B3nM72Ed3ZLBOL9FT4z1wnB9 >> g4%3D&reserved=0> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit> >> hub.com >> <http://hub.com/>%2Fapache%2Ftomee%2Ftree%2Fmaster%2Fexamples%2Fmp-metrics-meter >> ed&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com >> <http://40gemalto.com/>%7Cd28c5c4ecb2e4 >> 894702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C63682 >> 1974227610792&sdata=Rwo%2FYnhc9K4f74oknzIQ%2B5bMnNaNopdLuJYjoyjScv >> Q%3D&reserved=0 >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi> >> thub.com >> <http://thub.com/>%2Fapache%2Ftomee%2Ftree%2Fmaster%2Fexamples%2Fmp-metrics-mete >> red&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com >> <http://40gemalto.com/>%7Cd28c5c4ecb2e >> 4894702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C6368 >> 21974227610792&sdata=Rwo%2FYnhc9K4f74oknzIQ%2B5bMnNaNopdLuJYjoyjSc >> vQ%3D&reserved=0> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit> >> hub.com >> <http://hub.com/>%2Fapache%2Ftomee%2Ftree%2Fmaster%2Fexamples%2Fmp-metrics-timed >> &data=02%7C01%7CFrancois.COURTAULT%40gemalto.com >> <http://40gemalto.com/>%7Cd28c5c4ecb2e489 >> 4702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C6368219 >> 74227610792&sdata=Z2Gj0w5%2BHjY%2BzVukViR1Vvdkcj3VPR4EIyx%2Bs7zVXa >> E%3D&reserved=0 >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi >> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi> >> thub.com >> <http://thub.com/>%2Fapache%2Ftomee%2Ftree%2Fmaster%2Fexamples%2Fmp-metrics-time >> d&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com >> <http://40gemalto.com/>%7Cd28c5c4ecb2e48 >> 94702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C636821 >> 974227610792&sdata=Z2Gj0w5%2BHjY%2BzVukViR1Vvdkcj3VPR4EIyx%2Bs7zVX >> aE%3D&reserved=0> >> >> Cheers, >> Roberto >> >>> On 3 Jan 2019, at 17:23, COURTAULT Francois <francois.courta...@gemalto.com >>> <mailto:francois.courta...@gemalto.com>> wrote: >>> >>> Hello, >>> >>> Looking at >>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fis >>> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fis> >>> s >>> ues.apache.org >>> <http://ues.apache.org/>%2Fjira%2Fsecure%2FReleaseNote.jspa%3Fversion%3D1234384 >>> 7 >>> %26styleName%3DHtml%26projectId%3D12312320%26Create%3DCreate%26atl_to >>> k >>> en%3DA5KQ-2QAV-T4JA-FDED%257C5568e1c4aa2bd4f868c2c534352d83971d50919e >>> % >>> 257Clin&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com >>> <http://40gemalto.com/>%7Cb3bc96c >>> 4 >>> 03464f65d0f808d671ade6d2%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7 >>> C >>> 636821389050504460&sdata=xJMwmTfkowszaEaLvFgmd8CH4KKqalGhuoA1lqN1 >>> z >>> og%3D&reserved=0 >>> >>> I see: >>> [TOMEE-2215<https://emea01.safelinks.protection.outlook.com/?url=http >>> <https://emea01.safelinks.protection.outlook.com/?url=http> >>> s >>> %3A%2F%2Fissues.apache.org >>> <http://2fissues.apache.org/>%2Fjira%2Fbrowse%2FTOMEE-2215&data=02%7 >>> C >>> 01%7CFrancois.COURTAULT%40gemalto.com >>> <http://40gemalto.com/>%7Cb3bc96c403464f65d0f808d671ade >>> 6 >>> d2%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C636821389050504460&am >>> p >>> ;sdata=%2FfeTW8EAyPcIROL6ceUFwIob62zk8ZkmLWLU6B1md%2BE%3D&reserve >>> d >>> =0>] - MicroProfile Metrics 1.0 >>> >>> This seems quite confusing because, we might think that TomEE 7.1 support >>> metrics but if we look at >>> TOMEE-2215<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FTOMEE-2215&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com%7Cd28c5c4ecb2e4894702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C636821974227610792&sdata=%2FZP2oqv2gPs7rhYL25VBJIiUV2tKajfXDVX8mJa3VpI%3D&reserved=0 >>> >>> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FTOMEE-2215&data=02%7C01%7CFrancois.COURTAULT%40gemalto.com%7Cd28c5c4ecb2e4894702308d672362669%7C37d0a9db7c464096bfe31add5b495d6d%7C0%7C0%7C636821974227610792&sdata=%2FZP2oqv2gPs7rhYL25VBJIiUV2tKajfXDVX8mJa3VpI%3D&reserved=0>>], >>> it is written: >>> "Apparently the Metrics implementation requires CDI 2.0 and is only >>> available in TomEE 8." >>> So, it means that Geronimo Metrics 1.0.0 requires CDI 2.0, right ? >>> And then it means that Metrics is not supported by TomEE 7.1, right ? So >>> why is it listed in the TomEE 7.1 release note ? >>> >>> I was wondering if Metrics is working on TomEE 8.0.0 M1: I ran it but >>> if , through a browser, I want to have access at >>> http://localhost:8080/metrics/base, nothing is displayed :( (got a 404) >>> Could you confirm or not if Metrics is working on TomEE 8.0.0 M1 ? >>> >>> Best Regards. >>> ________________________________ >>> This message and any attachments are intended solely for the addressees and >>> may contain confidential information. Any unauthorized use or disclosure, >>> either whole or partial, is prohibited. >>> E-mails are susceptible to alteration. Our company shall not be liable for >>> the message if altered, changed or falsified. If you are not the intended >>> recipient of this message, please delete it and notify the sender. >>> Although all reasonable efforts have been made to keep this transmission >>> free from viruses, the sender will not be liable for damages caused by a >>> transmitted virus. >> >> ________________________________ >> This message and any attachments are intended solely for the addressees and >> may contain confidential information. Any unauthorized use or disclosure, >> either whole or partial, is prohibited. >> E-mails are susceptible to alteration. Our company shall not be liable for >> the message if altered, changed or falsified. If you are not the intended >> recipient of this message, please delete it and notify the sender. >> Although all reasonable efforts have been made to keep this transmission >> free from viruses, the sender will not be liable for damages caused by a >> transmitted virus. > > ________________________________ > This message and any attachments are intended solely for the addressees and > may contain confidential information. Any unauthorized use or disclosure, > either whole or partial, is prohibited. > E-mails are susceptible to alteration. Our company shall not be liable for > the message if altered, changed or falsified. If you are not the intended > recipient of this message, please delete it and notify the sender. > Although all reasonable efforts have been made to keep this transmission free > from viruses, the sender will not be liable for damages caused by a > transmitted virus.
