Hi Doychin,
I've run all the tests on the merge of the 5 PRs.
I encountered 2 errors. They might be transient ones. Can you please
take a look?
arquillian-tomee-jms-tests
[ERROR] EnvEntryTest.test:105 » EJB The bean encountered a
non-application exception; ...
openejb-core
[ERROR] AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
abandoned connection expected:<1> but was:<0>
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 18/01/19 18:32, Bruno Baptista wrote:
Hi Doychin,
Thanks for the contribution!
I've approved a couple and left comments in 2 others.
Will run all the tests when I get home.
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 18/01/19 17:46, Bruno Baptista wrote:
Hi Doychin,
I'll have a look.
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 18/01/19 17:41, Doychin Bondzhev wrote:
Hi guys,
Can some one take a look at following PR's?
Startup and shutdown fixes - TOMEE-2454
<https://github.com/apache/tomee/pull/371>
increase the time to wait for sweeps.
<https://github.com/apache/tomee/pull/363>
Make observers more CDI like. This will make the commented test to
work. <https://github.com/apache/tomee/pull/362>
Issue is closed and TomEE uses more recent version
<https://github.com/apache/tomee/pull/361>
Cleanup test code and also minor changes in the tested class.
<https://github.com/apache/tomee/pull/360>
thanks
--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116