I wonder why that check is there. What is it trying to prevent?

In the meanwhile I was trying to figure out another issue with the tomee webapp 
deployment, since it is failing the tests and I don’t want to move into 
changing that without making sure every test is passing.

Would it be possible for you to contribute to the Test Case that I wrote, with 
those details, so it would be easier to test changes or fixes?

Thanks!

> On 31 Jan 2019, at 21:27, j4fm <[email protected]> wrote:
> 
> I removed all the configs disabling the filters! It seems that has the wrong
> effect in actually disabling the CustomServlet from being processed in
> servletMappingIsUnderRestPath.
> 
> Now I have this code running in servletMappingIsUnderRestPath:
> 
>            if (accept == null) {
>            accept = false;
>            for (final String mapping : wrapper.findMappings()) {
>                    if (!mapping.isEmpty() && !"/*".equals(mapping) &&
> !"/".equals(mapping) && !mapping.startsWith("*")
>                            && mapping.startsWith(this.mapping)) {
>                        accept = true;
>                        break;
>                    }
>                }
> 
> But it doesn't set accept true because the filter happens to be *.abc and
> there is that condition !mapping.startsWith("*").
> 
> So it still returns false and the chain is not continued.  So looks like a
> 2nd issue with the filter, possibly a 3rd with the filter.active config.
> 
> 
> 
> --
> Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Reply via email to