Hi JL, I believe now we're in a good shape to merge the PR. Please, review it. :)
Em dom, 24 de fev de 2019 às 15:53, Jean-Louis Monteiro < jlmonte...@tomitribe.com> escreveu: > Lol > > Le dim. 24 févr. 2019 à 13:11, Daniel Cunha <daniels...@apache.org> a > écrit : > > > oops, nevermind. > > I was looking for the wrong PR. > > > > Em dom, 24 de fev de 2019 às 09:10, Daniel Cunha <daniels...@apache.org> > > escreveu: > > > > > Ok, > > > > > > Seems that PR already merged. > > > I'll work to fix the headers. > > > > > > Em dom, 24 de fev de 2019 às 07:58, Daniel Cunha <daniels...@gmail.com > > > > > escreveu: > > > > > >> Hi JL, > > >> > > >> Yeah, I can fix it. > > >> I'll update the PR. > > >> > > >> Em dom, 24 de fev de 2019 às 07:55, Jean-Louis Monteiro < > > >> jlmonte...@tomitribe.com> escreveu: > > >> > > >>> Do you think you can add at the beginning the adoc headers for JBake? > > >>> > > >>> Even the index group you might be able to guess it based on the > > directory > > >>> name. It might not be 100% accurate but at least people can fix it > > after. > > >>> > > >>> If not, don't worry, I'll merge and add them after. > > >>> > > >>> > > >>> > > >>> -- > > >>> Jean-Louis Monteiro > > >>> http://twitter.com/jlouismonteiro > > >>> http://www.tomitribe.com > > >>> > > >>> > > >>> On Sat, Feb 23, 2019 at 7:59 PM Daniel Cunha <daniels...@apache.org> > > >>> wrote: > > >>> > > >>> > Hi JL, > > >>> > > > >>> > That is the PR moving all md to adoc. :) > > >>> > https://github.com/apache/tomee/pull/413 > > >>> > > > >>> > What I did: > > >>> > > > >>> > find . -name "README.md" -type f -exec pandoc -s -t markdown-smart > {} > > >>> -t > > >>> > asciidoc -o {} \; > > >>> > find . -name README.md | sed -e "p;s/md/adoc/" | xargs -n2 mv > > >>> > > > >>> > Em sáb, 23 de fev de 2019 às 08:12, Jean-Louis Monteiro < > > >>> > jlmonte...@tomitribe.com> escreveu: > > >>> > > > >>> > > Awesome. > > >>> > > Yeah, I'd like all the technical switch from markdown to be done > > >>> once and > > >>> > > then we can focus on the content. > > >>> > > > > >>> > > Having tons of PR just to convert from one format to the other is > > not > > >>> > idea > > >>> > > or useful let's say > > >>> > > > > >>> > > Thanks > > >>> > > > > >>> > > > > >>> > > -- > > >>> > > Jean-Louis Monteiro > > >>> > > http://twitter.com/jlouismonteiro > > >>> > > http://www.tomitribe.com > > >>> > > > > >>> > > > > >>> > > On Sat, Feb 23, 2019 at 12:09 PM Daniel Cunha < > > daniels...@apache.org > > >>> > > > >>> > > wrote: > > >>> > > > > >>> > > > Hi JL, > > >>> > > > > > >>> > > > that is what I was thinking to do. > > >>> > > > pandoc is exactly what I'm testing now and seems that it works > > >>> fine. > > >>> > > > > > >>> > > > Em sáb, 23 de fev de 2019 às 07:56, Jean-Louis Monteiro < > > >>> > > > jlmonte...@tomitribe.com> escreveu: > > >>> > > > > > >>> > > > > Is there a way we can script some and convert them all at > once? > > >>> > > > > > > >>> > > > > For instance using something like pandoc to convert from > > >>> markdown to > > >>> > > > > asciidoc and then add the headers with a shell script? > > >>> > > > > > > >>> > > > > What do you think? > > >>> > > > > > > >>> > > > > We would have them all converted the same way and we would > then > > >>> just > > >>> > > need > > >>> > > > > to improve the content. > > >>> > > > > > > >>> > > > > -- > > >>> > > > > Jean-Louis Monteiro > > >>> > > > > http://twitter.com/jlouismonteiro > > >>> > > > > http://www.tomitribe.com > > >>> > > > > > > >>> > > > > > > >>> > > > > On Fri, Feb 22, 2019 at 4:23 PM Daniel Cunha < > > >>> daniels...@apache.org> > > >>> > > > > wrote: > > >>> > > > > > > >>> > > > > > Hi Folks, > > >>> > > > > > > > >>> > > > > > Getting back the work to move README from md to adoc. > > >>> > > > > > That is first PR and sample to be reviwed: > > >>> > > > > > https://github.com/apache/tomee/pull/408 > > >>> > > > > > > > >>> > > > > > Please review it and see if that is what we are expecting > > have, > > >>> > then > > >>> > > > I'll > > >>> > > > > > continue the work on it. > > >>> > > > > > > > >>> > > > > > Thanks. :) > > >>> > > > > > > > >>> > > > > > -- > > >>> > > > > > Daniel "soro" Cunha > > >>> > > > > > https://twitter.com/dvlc_ > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > > >>> > > > -- > > >>> > > > Daniel "soro" Cunha > > >>> > > > https://twitter.com/dvlc_ > > >>> > > > > > >>> > > > > >>> > > > >>> > > > >>> > -- > > >>> > Daniel "soro" Cunha > > >>> > https://twitter.com/dvlc_ > > >>> > > > >>> > > >> > > >> > > >> -- > > >> Daniel "soro" Cunha > > >> https://twitter.com/dvlc_ > > >> > > > > > > > > > -- > > > Daniel "soro" Cunha > > > https://twitter.com/dvlc_ > > > > > > > > > -- > > Daniel "soro" Cunha > > https://twitter.com/dvlc_ > > > -- Daniel "soro" Cunha https://twitter.com/dvlc_
