Hi James! Thanks for the PR and good goal -- anytime there are jar file names in code, it's a code smell. I say that having broken that rule myself.
On the PR, my memory of that usage of Class.forName is that looks in the system classpath only and is a repeat source of disappointment. As the lib/ jars are in a child ClassLoader of the system classloader, I'd expect a ClassNotFoundException every time. We do have a utility class to try and define jar locations from the class which is used in a handful of places: - https://github.com/apache/tomee/blob/master/container/openejb-loader/src/main/java/org/apache/openejb/loader/JarLocation.java#L71 I don't know how well it will stand up to our Java 11 work and the introduction of the module classpath, which as I understand doesn't use file: or jar: URLs. I guess, however, any motivation to tinker with jars wouldn't fit in that world anyway. Do you know why we need the jar locations in the first place? Side note, I've been noticing a lot of great contributions from you. Thank you for being here. :) I'm excited to finally get my turn to work with you :) -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com > On Feb 25, 2019, at 4:01 PM, GitBox <[email protected]> wrote: > > j4fm opened a new pull request #416: TOMEE-2408 Remove dependency on MP JAR > filenames > URL: https://github.com/apache/tomee/pull/416 > > > > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > [email protected] > > > With regards, > Apache Git Services
