jgallimore commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/427#issuecomment-469218713 In`LocalJMXCommand` the PropertyEditorRegistry is held as a field. In other places, this is doing `PropertyEditorRegistry.registerDefaults()` when calling `getValue()`, which has to go an do a bunch of registration each time. What do we think the lifecycle of a `PropertyEditorRegistry` should be? I did a quick search for references, which throws up `ManagedMBean`, `ActiveMQ5Factory`, `JMSProducerImpl`, and I would have thought it could be tied to the lifecycle of the components using it in each case (i.e. - make it a field). Thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
