Merged those, thanks for picking that up! On Sat, 16 Mar 2019, 16:02 Daniel Cunha, <daniels...@apache.org> wrote:
> Hi, > > seems that got a checkstyle error for TomEE 7.0.x and TomEE 7.1.x. > One sample is not passing during the build, which is weird. It's passing > locally. > > PR to fix checkstyles: > https://github.com/apache/tomee/pull/443 > https://github.com/apache/tomee/pull/444 > > > Em sáb, 16 de mar de 2019 às 09:00, Daniel Cunha <daniels...@apache.org> > escreveu: > > > Just waiting the buildbot result to mark the issue as solved. :) > > > > Em sáb, 16 de mar de 2019 às 08:57, Daniel Cunha <daniels...@apache.org> > > escreveu: > > > >> Thanks Jon! :) > >> > >> Em sáb, 16 de mar de 2019 às 08:56, Jonathan Gallimore < > >> jonathan.gallim...@gmail.com> escreveu: > >> > >>> Just merged your back ports too. Thanks Dani. > >>> > >>> Jon > >>> > >>> On Fri, 15 Mar 2019, 16:45 Daniel Cunha, <daniels...@apache.org> > wrote: > >>> > >>> > Build fine! > >>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1055 > :) > >>> > Going to backport it to TomEE 7.0.x and TomEE 7.1.x > >>> > > >>> > Em sex, 15 de mar de 2019 às 11:11, Daniel Cunha < > >>> daniels...@apache.org> > >>> > escreveu: > >>> > > >>> > > I will. > >>> > > Thank you Jon. :) > >>> > > > >>> > > Em sex, 15 de mar de 2019 às 11:06, Jonathan Gallimore < > >>> > > jonathan.gallim...@gmail.com> escreveu: > >>> > > > >>> > >> Merged, thank Dani. If you can keep an eye on buildbot for any > >>> issues, > >>> > I'd > >>> > >> appreciate it. > >>> > >> > >>> > >> Thanks > >>> > >> > >>> > >> Jon > >>> > >> > >>> > >> On Fri, Mar 15, 2019 at 1:32 PM Daniel Cunha < > daniels...@apache.org > >>> > > >>> > >> wrote: > >>> > >> > >>> > >> > Hi folks, > >>> > >> > > >>> > >> > Dependency upgrade. Upgrade for bcprov-jdk15on: > >>> > >> > https://issues.apache.org/jira/browse/TOMEE-2493 > >>> > >> > > >>> > >> > I'll push the updates for 7.0.x and 7.1.x when you have it > merged > >>> on > >>> > >> > master. > >>> > >> > PR to be reviewed: https://github.com/apache/tomee/pull/440 > >>> > >> > > >>> > >> > > >>> > >> > -- > >>> > >> > Daniel "soro" Cunha > >>> > >> > https://twitter.com/dvlc_ > >>> > >> > > >>> > >> > >>> > > > >>> > > > >>> > > -- > >>> > > Daniel "soro" Cunha > >>> > > https://twitter.com/dvlc_ > >>> > > > >>> > > >>> > > >>> > -- > >>> > Daniel "soro" Cunha > >>> > https://twitter.com/dvlc_ > >>> > > >>> > >> > >> > >> -- > >> Daniel "soro" Cunha > >> https://twitter.com/dvlc_ > >> > > > > > > -- > > Daniel "soro" Cunha > > https://twitter.com/dvlc_ > > > > > -- > Daniel "soro" Cunha > https://twitter.com/dvlc_ >
