cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example URL: https://github.com/apache/tomee/pull/488#discussion_r295012658
########## File path: examples/xa-datasource/src/main/webapp/WEB-INF/resources.xml ########## @@ -0,0 +1,46 @@ +<resources> + + <Resource id="movieDatabase" type="DataSource"> + JdbcDriver org.apache.derby.jdbc.EmbeddedXADataSource + JdbcUrl jdbc:derby:testdb;create=true + UserName admin + Password admin + ValidationQuery=values 1 + InitialSize=2 + MaxActive=128 + MaxIdle=25 + MinIdle=10 + TestWhileIdle=true + TestOnBorrow=false + TestOnReturn=false + AccessToUnderlyingConnectionAllowed=true + TimeBetweenEvictionRuns=1 minute + MaxWaitTime=0 seconds + JtaManaged=true + PoolPreparedStatements=true + MaxOpenPreparedStatements=1024 + User=admin + DatabaseName=testdb + CreateDatabase=true Review comment: This triggers the following Warning ``` 18-Jun-2019 14:22:59.605 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'CreateDatabase' for resource 'dbtest/movieDatabase' ``` The property is not part of Tomcat jdbc pool: https://tomcat.apache.org/tomcat-8.0-doc/jdbc-pool.html ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
