Thanks David. New build ... https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1143
-- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Aug 5, 2019 at 3:20 PM David Blevins <dblev...@tomitribe.com> wrote: > > On Aug 5, 2019, at 6:14 AM, Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > > > I fixed it a while back, but when I reverted last week, I reverted the > fix > > as well. > > Sorry about that, I'll fix now. > > No apologies necessary. As the saying goes, the only people who don't > break the build are those who do nothing :) > > So congratulations is the better sentiment :) > > > -David > > > On Mon, Aug 5, 2019 at 3:12 PM David Blevins <david.blev...@gmail.com> > > wrote: > > > >> First step would be to get the build passing again. There are failures > >> which are not related to bean validation. > >> > >> Once those are fixed and our build is green again, I'll do the work to > >> disable the feature I added that needs a modified BVal. I hesitate to > do > >> it now because the build isn't passing now for unrelated reasons and > >> disabling and changing the BVal version won't fix it. > >> > >> Looks like it broke with this commit: > >> > >> - > >> > https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75 > >> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130 > >> > >> > >> -- > >> David Blevins > >> http://twitter.com/dblevins > >> http://www.tomitribe.com > >> > >>> On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro < > >> jlmonte...@tomitribe.com> wrote: > >>> > >>> Just looked at it today. > >>> Looks like the build has > >>> > >>> <dependency> > >>> <groupId>org.apache.tomee.patch</groupId> > >>> <artifactId>bval-jsr</artifactId> > >>> <version>2.0.2-69c36fa8-1</version> > >>> </dependency> > >>> But available from maven central is > >>> > >>> > >>> Should we update to one of those? > >>> Should we go to the official final? > >>> > >>> Can you guys give some hints so I can fix it? > >>> > >>> > >>> -- > >>> Jean-Louis Monteiro > >>> http://twitter.com/jlouismonteiro > >>> http://www.tomitribe.com > >>> > >>> > >>> On Sat, Aug 3, 2019 at 2:59 AM David Blevins <david.blev...@gmail.com> > >> wrote: > >>>> On Aug 2, 2019, at 4:19 PM, David Blevins <david.blev...@gmail.com> > >> wrote: > >>>> > >>>> We can delete/disable the feature as well. I don't want to be the guy > >> holding up the show. > >>> > >>> Dug in to take this route as it's all around simpler. It looks, > >> however, the build has been failing since the 12th and it's all the JWT > >> code. > >>> > >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130 > >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137 > >>> > >>> I unfortunately don't have time to "shave the yak" so to speak. I'm > >> writing a Github App to implement checks on the 37 Jakarta EE > >> specifications that all need to go up for vote in the next two weeks or > >> there will be no Jakarta EE 8 by CodeOne. This includes the Bean > >> Validation specification, tck, itself. > >>> > >>> Jean-Louis, looks like this is related to the commit and revert you > >> might have done. We had a pass on the 26th, which I suspect is right > >> before you did the revert. > >>> > >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136 > >>> > >>> If you can reinstate the fix, I'll go ahead and disable the fancy > >> JWT/BeanValidation feature. > >>> > >>> > >>> -David > >>> > >> > >> > >
