Hello, the @hbelmiro made a review .
Can any committer take the PR forward? thank you -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em qua., 20 de mai. de 2020 às 20:22, Daniel Dias Dos Santos < daniel.dias.analist...@gmail.com> escreveu: > Hello Cesar , > > I created the pr with a message to commit the ticket number, but I think > it has not yet been integrated. > > -- > > *Daniel Dias dos Santos* > Java Developer > SouJava & JCP Member > GitHub: https://github.com/Daniel-Dos > Linkedin: www.linkedin.com/in/danieldiasjava > Twitter: http://twitter.com/danieldiasjava > > > Em qua., 20 de mai. de 2020 às 00:22, Daniel Dias Dos Santos < > daniel.dias.analist...@gmail.com> escreveu: > >> Hello Cesar, >> >> I will make an test tomorrow in other commit. >> >> thanks fo the links : ) >> -- >> >> *Daniel Dias dos Santos* >> Java Developer >> SouJava & JCP Member >> GitHub: https://github.com/Daniel-Dos >> Linkedin: www.linkedin.com/in/danieldiasjava >> Twitter: http://twitter.com/danieldiasjava >> >> >> Em ter., 19 de mai. de 2020 às 23:25, Cesar Hernandez < >> cesargu...@gmail.com> escreveu: >> >>> Hi Daniel, >>> As a follow up on the Github/Jira integration, I found this >>> https://infra.apache.org/svngit2jira.html it seems the integration works >>> based on the commit message and not on the Pull Request title. >>> If this is our case, I think we can improve the Issues section from: >>> https://tomee.apache.org/community/sources.html >>> >>> >>> >>> El jue., 14 may. 2020 a las 13:54, Daniel Dias Dos Santos (< >>> daniel.dias.analist...@gmail.com>) escribió: >>> >>> > yes , sure : ) >>> > -- >>> > >>> > *Daniel Dias dos Santos* >>> > Java Developer >>> > SouJava & JCP Member >>> > GitHub: https://github.com/Daniel-Dos >>> > Linkedin: www.linkedin.com/in/danieldiasjava >>> > Twitter: http://twitter.com/danieldiasjava >>> > >>> > >>> > Em qui., 14 de mai. de 2020 às 15:27, Cesar Hernandez < >>> > cesargu...@gmail.com> >>> > escreveu: >>> > >>> > > I don't think the cloning process affects the hook between Github and >>> > JIRA, >>> > > but if it does please let us know so we can double-check with Apache >>> > > infra. >>> > > >>> > > El mié., 13 may. 2020 a las 20:58, Daniel Dias Dos Santos (< >>> > > daniel.dias.analist...@gmail.com>) escribió: >>> > > >>> > > > Hello Cesar, >>> > > > >>> > > > I create the Jira first . >>> > > > >>> > > > but, I do the clone of ticket . >>> > > > >>> > > > -- >>> > > > >>> > > > *Daniel Dias dos Santos* >>> > > > Java Developer >>> > > > SouJava & JCP Member >>> > > > GitHub: https://github.com/Daniel-Dos >>> > > > Linkedin: www.linkedin.com/in/danieldiasjava >>> > > > Twitter: http://twitter.com/danieldiasjava >>> > > > >>> > > > >>> > > > Em qua., 13 de mai. de 2020 às 23:43, Cesar Hernandez < >>> > > > cesargu...@gmail.com> >>> > > > escreveu: >>> > > > >>> > > > > Hi Danie, >>> > > > > I reviewed the PR, just waiting for a second pair of eyes for the >>> > > > > Portuguese content before moving it forward. >>> > > > > >>> > > > > As a side note, I notice that JIRA is not automatically >>> detecting the >>> > > PR >>> > > > > related to the ticket. >>> > > > > Do you create first the PR and then the JIRA? >>> > > > > >>> > > > > >>> > > > > El mar., 12 may. 2020 a las 18:32, Daniel Dias Dos Santos (< >>> > > > > daniel.dias.analist...@gmail.com>) escribió: >>> > > > > >>> > > > > > Hi, >>> > > > > > >>> > > > > > I created an PR [1] and ticket jira [2]. >>> > > > > > >>> > > > > > Can someone do a review >>> > > > > > >>> > > > > > thanks >>> > > > > > >>> > > > > > [1] https://github.com/apache/tomee/pull/641 >>> > > > > > [2] https://issues.apache.org/jira/browse/TOMEE-2816 >>> > > > > > -- >>> > > > > > >>> > > > > > *Daniel Dias dos Santos* >>> > > > > > Java Developer >>> > > > > > SouJava & JCP Member >>> > > > > > GitHub: https://github.com/Daniel-Dos >>> > > > > > Linkedin: www.linkedin.com/in/danieldiasjava >>> > > > > > Twitter: http://twitter.com/danieldiasjava >>> > > > > > >>> > > > > >>> > > > > >>> > > > > -- >>> > > > > Atentamente: >>> > > > > César Hernández. >>> > > > > >>> > > > >>> > > >>> > > >>> > > -- >>> > > Atentamente: >>> > > César Hernández. >>> > > >>> > >>> >>> >>> -- >>> Atentamente: >>> César Hernández. >>> >>
