Hi, David Salter, The PR #670 is WIP. I am already working on this due to the issue TOMEE-55. This issue implies in fixing the table in one of .adoc pages ( spring-ejb-and-jpa <http://tomee.apache.org/spring-ejb-and-jpa.html>) that has anchors to spring-integration project, thus was needed to bring it to tomee git.
Daniel, thanks for responding early! Em qui., 9 de jul. de 2020 às 16:32, Daniel Dias Dos Santos < [email protected]> escreveu: > thanks : ) > -- > > *Daniel Dias dos Santos* > Java Developer > SouJava & JCP Member > GitHub: https://github.com/Daniel-Dos > Linkedin: www.linkedin.com/in/danieldiasjava > Twitter: http://twitter.com/danieldiasjava > > > Em qui., 9 de jul. de 2020 às 16:26, David Salter <[email protected]> > escreveu: > > > OK, I think I see what's going on. :) > > > > The PR you referenced adds the example back into git and fixes the > > markup for the relevant pages. > > > > This all looks good, and that PR just needs to be progressed. > > > > So, I think we're good to close TOMEE-234 as a duplicate of TOMEE-55. > > > > I'll close TOMEE-234 and mark it as a duplicate. > > > > David. > > > > On 09/07/2020 20:13, Daniel Dias Dos Santos wrote: > > > now i was in doubt if the example is relevant or not is in the > > repository. > > > -- > > > > > > *Daniel Dias dos Santos* > > > Java Developer > > > SouJava & JCP Member > > > GitHub: https://github.com/Daniel-Dos > > > Linkedin: www.linkedin.com/in/danieldiasjava > > > Twitter: http://twitter.com/danieldiasjava > > > > > > > > > Em qui., 9 de jul. de 2020 às 16:02, David Salter < > [email protected]> > > > escreveu: > > > > > >> Interesting. I can see the example in there, but the example isn't in > > >> master > > >> > > >> I've also found that the example was deleted in 2012. > > >> > > >> Very confusing ! > > >> > > >> commit 87d953511e0245c1360b65f8e4f369cf884ab882 > > >> Author: Romain Manni-Bucau <[email protected]> > > >> Date: Sun Sep 16 11:05:24 2012 +0000 > > >> > > >> removing no more relevant example > > >> > > >> git-svn-id: > > >> https://svn.apache.org/repos/asf/openejb/trunk/openejb@1385245 > > >> 13f79535-47bb-0310-9956-ffa450edef68 > > >> > > >> delete mode 100755 examples/cdi-query/pom.xml > > >> delete mode 100755 > > >> > > >> > > > examples/cdi-query/src/main/java/org/superbiz/dynamic/EntityManagerProducer.java > > >> delete mode 100755 > > >> examples/cdi-query/src/main/java/org/superbiz/dynamic/User.java > > >> delete mode 100755 > > >> > examples/cdi-query/src/main/java/org/superbiz/dynamic/UserDao.java > > >> delete mode 100755 > > >> examples/cdi-query/src/main/resources/META-INF/beans.xml > > >> delete mode 100755 > > >> examples/cdi-query/src/main/resources/META-INF/persistence.xml > > >> delete mode 100755 > > >> > > examples/cdi-query/src/test/java/org/superbiz/dynamic/CdiQueryTest.java > > >> delete mode 100644 examples/spring-integration/README.md > > >> delete mode 100644 examples/spring-integration/pom.xml > > >> delete mode 100644 > > >> > > >> > > > examples/spring-integration/src/main/java/org/superbiz/spring/AvailableMovies.java > > >> delete mode 100644 > > >> > > >> > > > examples/spring-integration/src/main/java/org/superbiz/spring/Cineplex.java > > >> delete mode 100644 > > >> > > >> > > > examples/spring-integration/src/main/java/org/superbiz/spring/CineplexImpl.java > > >> delete mode 100644 > > >> > > >> > examples/spring-integration/src/main/java/org/superbiz/spring/Movie.java > > >> delete mode 100644 > > >> > > >> > > examples/spring-integration/src/main/java/org/superbiz/spring/Movies.java > > >> delete mode 100644 > > >> > > >> > > > examples/spring-integration/src/main/java/org/superbiz/spring/MoviesImpl.java > > >> delete mode 100644 > > >> > > >> > > > examples/spring-integration/src/main/java/org/superbiz/spring/Theater.java > > >> delete mode 100644 > > >> > > >> > > > examples/spring-integration/src/main/java/org/superbiz/spring/Theaters.java > > >> delete mode 100644 > > >> > examples/spring-integration/src/main/resources/META-INF/ejb-jar.xml > > >> delete mode 100644 > > >> > > examples/spring-integration/src/main/resources/META-INF/persistence.xml > > >> delete mode 100644 > > >> examples/spring-integration/src/main/resources/movies.xml > > >> delete mode 100644 > > >> > > >> > > > examples/spring-integration/src/test/java/org/superbiz/spring/MoviesTest.java > > >> > > >> > > >> On 09/07/2020 19:57, Daniel Dias Dos Santos wrote: > > >> > > > https://github.com/apache/tomee/pull/670/files#diff-d3e9b934d37dc55b33648dd0e9c27f82 > > >>> -- > > >>> > > >>> *Daniel Dias dos Santos* > > >>> Java Developer > > >>> SouJava & JCP Member > > >>> GitHub: https://github.com/Daniel-Dos > > >>> Linkedin: www.linkedin.com/in/danieldiasjava > > >>> Twitter: http://twitter.com/danieldiasjava > > >>> > > >>> > > >>> Em qui., 9 de jul. de 2020 às 15:55, Daniel Dias Dos Santos < > > >>> [email protected]> escreveu: > > >>> > > >>>> Hello @David Salter, > > >>>> > > >>>> have a PR for this -> https://github.com/apache/tomee/pull/670. > > >>>> > > >>>> But I don't know, if the example is still valid, > > >>>> -- > > >>>> > > >>>> *Daniel Dias dos Santos* > > >>>> Java Developer > > >>>> SouJava & JCP Member > > >>>> GitHub: https://github.com/Daniel-Dos > > >>>> Linkedin: www.linkedin.com/in/danieldiasjava > > >>>> Twitter: http://twitter.com/danieldiasjava > > >>>> > > >>>> > > >>>> Em qui., 9 de jul. de 2020 às 15:48, David Salter < > > [email protected] > > >>>> escreveu: > > >>>> > > >>>>> Hi, > > >>>>> > > >>>>> I've been looking through Jira and have found an issue about errors > > in > > >>>>> Spring EJB and JPA page. > > >>>>> > > >>>>> (https://issues.apache.org/jira/browse/TOMEE-234) > > >>>>> > > >>>>> The issue relates to the page > > >>>>> http://tomee.apache.org/spring-ejb-and-jpa.html where the examples > > for > > >>>>> the Spring-Integration sample are incorrectly referenced (they > > >> reference > > >>>>> svn instead of git) > > >>>>> > > >>>>> Looking at the examples in git however, the project > > spring-integration > > >>>>> is no longer in the examples repo. > > >>>>> > > >>>>> Doing some investigation, I've found a copy (the copy?) of the > > >>>>> spring-integration example at > > >>>>> > > >>>>> > > >> > > > http://people.apache.org/~dblevins/site////examples-trunk/spring-integration/ > > >>>>> I'm not sure why the example is not in git any more, but it does > look > > >>>>> pretty old. So should we try and bring this into git, or should we > > >>>>> retire this page and remove it from the site ? > > >>>>> > > >>>>> Ta. > > >>>>> > > >>>>> Dave. > > >>>>> > > >>>>> > > >>>>> -- > > >>>>> David Salter > > >>>>> > > >>>>> > > >> -- > > >> David Salter > > >> > > >> > > -- > > David Salter > > > > > > >
