cesarhernandezgt commented on pull request #5: URL: https://github.com/apache/tomee-patch-plugin/pull/5#issuecomment-1013501888
Thank you @rzo1 and @jeanouii for the review. Replying inline the feedback: > we should always skip signed jars. I think the list of jars that are signed should be agnostic to the plugin. Also managing the version for each jar would make this hard to maintain since signed the jars are actually the ones defined in the apache/tomee project and not the jars from the apache/tomee-patch-plugin. > I remember we had that kind of issue with EclipseLink when working on TCK Thank you for the pointer, this helped me to improve the solution I come up with in commit b79126f and allow the end-user to define the list of jars to skip as part of the maven plugin configuration section. This means that the end-user of the plugin (tomee source code for example) can define the jar and versions to skip when transformer and artifact as demonstrated in https://github.com/apache/tomee-patch-plugin/pull/5/commits/b79126ff8993bb0703b757aa2939d3b8d33f085c#diff-1194561cbea346acb1bea37d81fdf5c70def982dcbb0c64eca2a96bc51941124R125-R137 I tried this and it worked for both profiles in TomEE build code: https://github.com/apache/tomee/blob/f7b57d811081c5a729664e92ee28cd2fff8672f9/tomee/apache-tomee/pom.xml#L549-L556 What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
