rzo1 edited a comment on pull request #829:
URL: https://github.com/apache/tomee/pull/829#issuecomment-1079613423


   I think, that `GenerateBoms` works correctly and removes the things added in 
https://github.com/apache/tomee/commit/8d94db115f6a9f89b8ed09f9757b7b72d641c217 
here because we switched to 
   
   ```
     <dependency>
         <groupId>org.apache.tomee</groupId>
         <artifactId>microprofile-opentracing-api-shade</artifactId>
         <version>9.0.0-M8-SNAPSHOT</version>
         <exclusions>
           <exclusion>
             <artifactId>*</artifactId>
             <groupId>*</groupId>
           </exclusion>
         </exclusions>
       </dependency>
   ```
   
   Looking at the `pom.xml` before the `GenerateBoms` is triggered, I can see 
this one from 
https://github.com/apache/tomee/commit/8d94db115f6a9f89b8ed09f9757b7b72d641c217
   
   ````
     <dependency>
         <groupId>org.apache.geronimo</groupId>
         <artifactId>geronimo-health-common</artifactId>
         <version>2.0.1</version>
         <exclusions>
           <exclusion>
             <artifactId>*</artifactId>
             <groupId>*</groupId>
           </exclusion>
         </exclusions>
       </dependency>
       <dependency>
         <groupId>org.apache.geronimo</groupId>
         <artifactId>geronimo-health-common</artifactId>
         <version>2.0.1</version>
         <classifier>jakarta</classifier>
         <exclusions>
           <exclusion>
             <artifactId>*</artifactId>
             <groupId>*</groupId>
           </exclusion>
         </exclusions>
       </dependency>
   ```
   For me it looks like some local (?) hassle as the generated bom file now 
contains dependencies without jakarta modifier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to