rzo1 commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r872021449
##########
container/openejb-jee/src/test/resources/web-fragment-example.xml:
##########
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
This file misses a license header - subsequently, the license header checks
in CI will fail.
You can ake a look at the other descriptor files and just copy & paste the
ASF license header into this file.
##########
container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java:
##########
@@ -166,4 +167,12 @@ public JAXBElement<Webservices> createConnector(final
Webservices value) {
public JAXBElement<FacesConfig> createFacesConfig(final FacesConfig value)
{
return new JAXBElement<FacesConfig>(_FacesConfig_QNAME,
FacesConfig.class, null, value);
}
+
+ /**
+ * Create an instance of {@link JAXBElement }{@code <}{@link WebFragment
}{@code >}}
+ */
+ @XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee";, name =
"web-fragment")
Review Comment:
We might need to add `web-fragment` part to `ObjectFactory$JAXB` in
`openejb-jee-accessors` to fully support it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
