Hi Zoltán, thanks for your PR [1] !
It usually takes some time for peope to review a PR. The best way to proceed is, that - after you created a PR - you sent a follow up email on your mail thread in which you asked for issue assignment. GitHub mails are flodding our mailboxes and some people might have filters in place and do not see it. I left some comments. From a quick look at the codebase, I think, that we need to add the web fragment to the "openejb-jee-accessors" module as well (but I might be wrong ;) - at least this is done for all other descriptor types. A good place for a unit test would probably "openejb-core". Maybe something like org.apache.openejb.jee.servlet31.DontFailOnUnusedTagTest Gruß Richard [1] https://github.com/apache/tomee/pull/883 Am Donnerstag, dem 12.05.2022 um 18:10 +0200 schrieb Zoltán Tichov: > Hi! > > If I have a pending pull request, can I work on another issue as > well? > > Thanks: Zoltán > > On Tue, May 10, 2022 at 10:48 PM David Blevins < > david.blev...@gmail.com> > wrote: > > > Hi Zoltán! > > > > Really fantastic you have something working! > > > > If you create a PR that'a the best way to say "here are my changes, > > can > > you please review?" > > > > - > > https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request > > > > Any JDK 11 is fine since TomEE doesn't require a specific Java > > vendor -- > > any Java 11 version is good. > > > > Once you have that PR ready, feel free to update this thread with > > the > > link. Discussion can happen in the PR as well, but definitely more > > people > > see it here. > > > > > > -David > > > > > > > On May 10, 2022, at 11:06 AM, Zoltán Tichov < > > > zoltan.tic...@gmail.com> > > wrote: > > > Hi David! > > > > > > I made some changes and a testcase, how can I show these changes > > > to > > > somebody? > > > Which JDK should I use? Now I use adoptOpenJDK 11 to run the > > > tests. > > > > > > Thanks: Zoltán > > > > > > On Fri, May 6, 2022 at 1:27 AM David Blevins < > > > david.blev...@gmail.com> > > > wrote: > > > > > > > Hey Zoltán! > > > > > > > > Absolutely, you're welcome to fix the issue. I can assign the > > > > issue to > > > > you if you let me know your JIRA username. Make a comment on > > > > the issue > > and > > > > that'll be the quickest way to send it. > > > > > > > > We intentionally have it setup so new people can't assign > > > > issues to > > > > themselves so that they're forced to come to the list where we > > > > can get > > them > > > > off to the right start. > > > > > > > > On the issue you want to fix, most the code that would be > > > > involved in > > the > > > > fix is here: > > > > > > > > - > > > > > > https://github.com/apache/tomee/blob/master/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java > > > > Some important history to help you. When J2EE got renamed to > > > > Java EE, > > the > > > > namespaces changed. The TCK for full Java EE server tests that > > > > all > > > > historic namespaces can be supported. Our solution was to > > > > create an > > > > org.xml.sax.XMLFilter and dynamically rewrite the namespace on > > > > any > > document > > > > we were given to the then latest namespace > > > > http://java.sun.com/xml/ns/javaee > > > > > > > > - > > > > > > https://github.com/apache/tomee/blob/master/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java#L291 > > > > The way JAXB works is all the namespaces are hardcoded and > > > > without a > > > > filter like the one we made, there'd be no way to support > > > > multiple > > > > namespaces. Those namespaces are all here: > > > > > > > > - > > > > > > https://github.com/apache/tomee/blob/master/container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java > > > > I did most that work, but it was 15 years ago and I don't > > > > recall all the > > > > details. Jean-Louis did the work for the Jakarta namespace. I > > > > know > > we're > > > > testing at least some those old namespaces and the new > > > > namespace. We > > have > > > > some test descriptors here: > > > > > > > > - > > > > > > https://github.com/apache/tomee/tree/master/container/openejb-jee/src/test/resources > > > > I don't recall the name of those tests offhand, but if you > > > > search for > > the > > > > names of some of those files that should get you close. > > > > > > > > > > > > Now a couple thoughts as I see potential for some short-term > > > > work and > > some > > > > longer-term work. > > > > > > > > - Long-term: We're clearly still referring to " > > > > http://java.sun.com/xml/ns/javaee"; as the primary > > > > namespace. That's > > not > > > > going to age well. If someone has to write an email like this > > > > in 15 > > years, > > > > they'll likely have to explain what "javaee" is like I had to > > > > harken > > back > > > > to "J2EE". We should probably make the new Jakarta EE > > > > namespace be the > > > > primary namespace and rework all the JAXB code and namespace > > > > filters > > > > accordingly. > > > > > > > > - Short-term: Do not do any of that and avoid opening that can > > > > of worms > > > > at all cost. Get the file to parse with the minimum change > > > > possible. > > Get > > > > some experience with the code and a successful contribution in > > > > the can. > > > > > > > > This is what I'd do regardless of (or because of?) years of > > experience. I > > > > always take the quick win before attempting the big one. > > > > > > > > If you get into the code and decide the big change sounds like > > > > fun, we > > can > > > > make a ticket for it and plan it. Probably we'd want to shore > > > > up any > > test > > > > coverage we'd be lacking and also get a full TCK run to see > > > > what those > > > > numbers look like so we can spot regressions. > > > > > > > > Hope some of this is helpful! > > > > > > > > Don't hesitate to be super noisy and ask lots and lots of > > > > questions. > > > > Silence is death. :) > > > > > > > > > > > > -David > > > > > > > > > > > > > On May 5, 2022, at 3:31 PM, Zoltán Tichov < > > > > > zoltan.tic...@gmail.com> > > > > wrote: > > > > > Hi Richard! > > > > > I found a ticket with a bug that I also encountered.The > > > > > ticket is open > > > > and > > > > > unassigned. > > > > > Should I try to fix it? If so, how can it be assigned to me? > > > > > https://issues.apache.org/jira/browse/TOMEE-3824 > > > > > > > > > > Best: Zoltán > > > > > > > > > > On Wed, Apr 27, 2022 at 8:36 AM Zowalla, Richard < > > > > > richard.zowa...@hs-heilbronn.de> wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > it would certainly help to track these issues as an issue. > > > > > > > > > > > > Maybe they are already solved (as the code has evolved) but > > > > > > maybe not, > > > > > > so it would be good to have them. > > > > > > > > > > > > Gruß > > > > > > Richard > > > > > > > > > > > > Am Dienstag, dem 26.04.2022 um 21:54 +0200 schrieb Zoltán > > > > > > Tichov: > > > > > > > Hi Richard! > > > > > > > > > > > > > > I have found two errors in Tomee 9.0.0-M7. Should I make > > > > > > > tickets for > > > > > > > these > > > > > > > errors and try to fix them? > > > > > > > Although they may have been fixed in the next version > > > > > > > (9.0.0-M8) > > > > > > > > > > > > > > Zoltán > > > > > > > > > > > > > > On Sun, Apr 24, 2022 at 11:06 AM Zowalla, Richard < > > > > > > > richard.zowa...@hs-heilbronn.de> wrote: > > > > > > > > > > > > > > > Hi Zoltán, > > > > > > > > > > > > > > > > It's very great from you and it's truly awesome when a > > > > > > > > long time > > > > > > > > user > > > > > > > > of TomEE decides to contribute :) > > > > > > > > > > > > > > > > First of all, do not get intimidated by your first > > > > > > > > ticket. If it > > > > > > > > ends > > > > > > > > up being too hard or just not fun, let's find something > > > > > > > > else for > > > > > > > > you. > > > > > > > > There is always plenty of work to do. > > > > > > > > > > > > > > > > We are currently working on TomEE 9. Therefore, we > > > > > > > > moved away from > > > > > > > > our > > > > > > > > previous byte code transformation approach and switched > > > > > > > > TomEE > > > > > > > > master to > > > > > > > > TomEE 9 (Jakarta). > > > > > > > > > > > > > > > > While we made good progress, there is still a lot todo. > > > > > > > > The efforts > > > > > > > > and > > > > > > > > open tasks are tracked in [1]. A lot of effort is > > > > > > > > currently done to > > > > > > > > switch the MicroProfile impl to MP Smallrye impls in > > > > > > > > order to move > > > > > > > > to > > > > > > > > the jakarta namespace [2]. > > > > > > > > > > > > > > > > If you are interested in contributing to our TomEE 9 > > > > > > > > efforts, we > > > > > > > > can > > > > > > > > surely find some beginner friendly tasks in this area. > > > > > > > > > > > > > > > > Gruß > > > > > > > > Richard > > > > > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/TOMEE-3862 > > > > > > > > [2] > > > > > > > > https://lists.apache.org/thread/hdntdhwqkr91o2mszojq66qcfzszw96p > > > > > > > > > > > > > > > > > > > > > > > > Am Samstag, dem 23.04.2022 um 20:21 +0200 schrieb > > > > > > > > Zoltán Tichov: > > > > > > > > > Hi! > > > > > > > > > > > > > > > > > > I live in Hungary. I am working at an IT company as a > > > > > > > > > software > > > > > > > > > developer, I > > > > > > > > > develop java > > > > > > > > > webapps with jsf (PrimeFaces) and microservice like > > > > > > > > > apps without > > > > > > > > > any > > > > > > > > > container technology > > > > > > > > > and Oracle database. > > > > > > > > > > > > > > > > > > We want to switch to jakarta ee 9 at the company, but > > > > > > > > > unfortunately > > > > > > > > > we ran > > > > > > > > > into problems with tomee 9 and I would like to > > > > > > > > > contribute to > > > > > > > > > fixing > > > > > > > > > these > > > > > > > > > bugs and possibly improving tomee jakarta 10. (I'm > > > > > > > > > sorry to read > > > > > > > > > on > > > > > > > > > another > > > > > > > > > tomee mailing list, that you had to skip jakarta ee 8 > > > > > > > > > and 9 > > > > > > > > > compliance > > > > > > > > > entirely) > > > > > > > > > I use java 11 and netbeans on windows 10. If we don't > > > > > > > > > have to, we > > > > > > > > > don't > > > > > > > > > want to use another app server because we've been > > > > > > > > > using tomee > > > > > > > > > since > > > > > > > > > 1.7.3. > > > > > > > > > > > > > > > > > > Best regards: Zoltán Tichov
smime.p7s
Description: S/MIME cryptographic signature
