rzo1 commented on code in PR #891:
URL: https://github.com/apache/tomee/pull/891#discussion_r906807788
##########
examples/arquillian-jpa/pom.xml:
##########
@@ -28,10 +28,22 @@ language governing permissions and limitations under the
License. -->
<artifactId>maven-compiler-plugin</artifactId>
<version>3.5.1</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>11</source>
+ <target>11</target>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.22.2</version>
Review Comment:
Can we use `3.0.0-M5` or higher here?
##########
examples/arquillian-jpa/pom.xml:
##########
@@ -28,10 +28,22 @@ language governing permissions and limitations under the
License. -->
<artifactId>maven-compiler-plugin</artifactId>
<version>3.5.1</version>
Review Comment:
Can we use `3.10.1` ?
##########
examples/arquillian-jpa/pom.xml:
##########
@@ -105,6 +106,33 @@ language governing permissions and limitations under the
License. -->
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.jboss.arquillian.junit5</groupId>
+ <artifactId>arquillian-junit5-container</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.jboss.arquillian.junit5</groupId>
+ <artifactId>arquillian-junit5-core</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <scope>test</scope>
+ <type>jar</type>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.13.2</version>
Review Comment:
It looks like the tests were migrated towards JUnit 5 - do we still need
JUnit4 here?
##########
examples/arquillian-jpa/src/test/resources/arquillian.xml:
##########
@@ -25,7 +25,7 @@
<property
name="defaultDataSource">openejb:Resource/demoDataSource</property>
</extension>
- <container qualifier="tomee" default="true">
+ <container qualifier="tomee-embedded" default="true">
Review Comment:
Looks like it changed from embedded to remote?`If so, we might need to
update the `README` as well?
##########
examples/arquillian-jpa/pom.xml:
##########
@@ -28,10 +28,22 @@ language governing permissions and limitations under the
License. -->
<artifactId>maven-compiler-plugin</artifactId>
<version>3.5.1</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>11</source>
+ <target>11</target>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.22.2</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>5.7.0</version>
Review Comment:
Any reason for `5.7.0` vs `5.8.2` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
