tichovz commented on code in PR #891:
URL: https://github.com/apache/tomee/pull/891#discussion_r906866572
##########
examples/arquillian-jpa/pom.xml:
##########
@@ -28,10 +28,22 @@ language governing permissions and limitations under the
License. -->
<artifactId>maven-compiler-plugin</artifactId>
<version>3.5.1</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>11</source>
+ <target>11</target>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.22.2</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>5.7.0</version>
Review Comment:
There is no particular reason the use of 5.7.0 so I upgraded it to 5.8.2
##########
examples/arquillian-jpa/pom.xml:
##########
@@ -28,10 +28,22 @@ language governing permissions and limitations under the
License. -->
<artifactId>maven-compiler-plugin</artifactId>
<version>3.5.1</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>11</source>
+ <target>11</target>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.22.2</version>
Review Comment:
Yes, we can, so I upgraded it to 3.0.0-M7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
