dblevins commented on PR #928: URL: https://github.com/apache/tomee/pull/928#issuecomment-1261242285
I think it's fantastic to get the version strings normalized to `version.foo`. We started with `foo.version` and gradually changed to `version.foo` as that kind of thing became more favored by Maven in general, but we never went back and fixed the old properties so we have a mix. Great to see that addressed. My preference would be to keep it short and go with straight `version.foo` versus adding prefixes before the `foo` part such as `tomee`, `api` or the groupId. I'll never remember which prefix rule goes where and when, so I'll constantly be looking it up and also further adding to inconsistency. Intellij does have completion for Maven properties. Being able to type `version.` and then get a flat list of all the names would be fantastic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
