> On Oct 20, 2022, at 4:01 PM, Cesar Hernandez <[email protected]> wrote: > > I pulled the latest main branch locally and compile it (mvn compile > -Djbake.http=true), but the server doesn't seem to be working. > This PR add basic Github Action so we can validate building on each PR > https://github.com/apache/tomee-site-generator/pull/52 we can add Jenkins > pipeline too, but I'm doing git bisect to see how we can add a check(s) > after maven build is successful in trying to validate from CI if all the > JBake requirements are met.
Some checks would be great. One thought that I had is that it's kind of a problem that the Jenkins job always passes, even if not much occurs and we end up with say just javadoc -- or no javadoc :) I did try to do a git bisect, but it didn't really work out as the old revisions that reference the master branch may have worked then, but definitely won't work now. I tried a couple things and gave up. In terms of checks one that would be critical would be to check to see that an html file was created for every .md or .adoc file. If not fail the build. That might be a little too strict at first as I'm sure we have a few adoc files that have issues and don't render even when things are good, but we could maybe get that list and 1) exclude them from the check and 2) fix them over time and yank them from the exclude list. Some thoughts at least. -David
smime.p7s
Description: S/MIME cryptographic signature
