Hi! Yes, I can include, but I made itest that were all green under 9.0 but they failed under 10.x. Errors may be caused by the server issuing different log messages in version 10 than in version 9. Should I fix them or is it OK later?
Thanks: Zoltán On Wed, Nov 29, 2023 at 8:37 AM rzo1 (via GitHub) <g...@apache.org> wrote: > > rzo1 commented on code in PR #990: > URL: https://github.com/apache/tomee/pull/990#discussion_r1408864908 > > > ########## > > mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/config/JWTAuthConfigurationProperties.java: > ########## > @@ -117,6 +119,15 @@ private JWTAuthConfiguration > createJWTAuthConfiguration() { > config.getOptionalValue("mp.jwt.decrypt.key.algorithm", > String.class).orElse(null), > > config.getOptionalValue("mp.jwt.verify.publickey.algorithm", > String.class).orElse(null)); > } > + > + private Boolean queryAllowExp(){ > > Review Comment: > @tichovz Can you include the feedback provided by Romain? :) > > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > >
