I am not suggesting doing "everything" via SBT, just the basic compile, test, build and package so that contributors used to other sbt based projects fill comfortable getting started with the project. For all the other more optional/complex tasks, I am all for using a set of fully documented tasks.
On Thu, Feb 2, 2017 at 7:23 AM, Corey Stubbs <cas5...@gmail.com> wrote: > My typical development flow is to write code, run pip-release , and then > install the pip release locally on my machine (pip install > dist/toree-pip/pip-release; jupyter toree install), and test changes with > the install. > > +1 on working on documenting the make targets. > > In terms of getting everything done via SBT, I don't know if that will > ultimately be possible. Targets like, compile, test, and build can (and a > majority should be) done with SBT. However, since we are doing some python > things to ease the pain of installing toree as a kernel into the Jupyter > environment (via pip install). > > Regardless, I agree the Makefile has become out of hand and can use some > cleanup and loving. > > I can start the work on documenting the targets that are there and clean up > old ones. Once I get a PR open I will post it here and in the related > issue: https://issues.apache.org/jira/browse/TOREE-367 > > On Tue, Jan 31, 2017 at 1:47 PM Luciano Resende <luckbr1...@gmail.com> > wrote: > > > On Tue, Jan 31, 2017 at 9:56 AM, Marius van Niekerk < > > marius.v.niek...@gmail.com> wrote: > > > > > I think just documenting development workflow and process properly will > > > help a great deal. > > > Building Toree is a non-trivial exercise sadly. > > > > > > > > Completely agree that is a non-trivial exercise, but should not be. > > > > > > -- > > Luciano Resende > > http://twitter.com/lresende1975 > > http://lresende.blogspot.com/ > > > -- Luciano Resende http://twitter.com/lresende1975 http://lresende.blogspot.com/
