[
https://issues.apache.org/jira/browse/TOREE-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048195#comment-16048195
]
ASF GitHub Bot commented on TOREE-380:
--------------------------------------
Github user chipsenkbeil commented on a diff in the pull request:
https://github.com/apache/incubator-toree/pull/104#discussion_r121751667
--- Diff:
kernel/src/test/scala/org/apache/toree/kernel/protocol/v5/relay/ExecuteRequestRelaySpec.scala
---
@@ -88,7 +89,7 @@ class ExecuteRequestRelaySpec extends TestKit(
// Expected does not actually match real return of magic, which
// is a tuple of ExecuteReply and ExecuteResult
val expected = new ExecuteAborted()
- interpreterActorProbe.expectMsgClass(
+ interpreterActorProbe.expectMsgClass(max = Duration(5,
TimeUnit.SECONDS),
--- End diff --
Rather than hard coding the duration to 5 seconds, we should have a
constant somewhere defined to that duration. Furthermore, I'm trying to
remember how akka's testkit time scaling works. I honestly can't remember, but
we want to make sure that it does indeed scale according to our config. I think
testkit does that for us, so this should be fine, but we probably need to
double-check.
> Interpreters should be allowed to send results other than text/plain.
> ---------------------------------------------------------------------
>
> Key: TOREE-380
> URL: https://issues.apache.org/jira/browse/TOREE-380
> Project: TOREE
> Issue Type: Improvement
> Reporter: Ryan Blue
> Assignee: Ryan Blue
>
> Jupyter allows kernels to send results using different content types, but
> this isn't allowed by Toree for its interpreters. This prevents custom
> display logic. The basic problem is that {{ExecuteOutput}} is a {{String}}
> and not a {{Map[String, String]}} like {{CellMagicOutput}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
