+1 on this feature, but I'm -1 on tying the fate of this feature to deprecation of the use of query parameters in Traffic Router.
While I really want to see deprecation of the use of query parameters in Traffic Router, we have some use cases that currently require them, in particular `ttred`. I don't know how prevalent the other two are (format, fakeClientIpAddress) in practice, but that needs to be investigated. Because of this, we need to do some work to determine which query parameters can be eliminated and what we need to do to continue supporting our existing use cases. If we must continue to support them, we might be able to find a slightly better approach that constrains their use to specific delivery services. For that reason, deprecation of these query parameters should be a distinct development effort. That also means we will need to account for them in this feature and ignore them when determining the string to use with consistent hashing and cache selection. -- Thanks, Jeff On Tue, May 7, 2019 at 9:01 AM Fieck, Brennan <[email protected]> wrote: > > Personally I'd like to see this accompanied by an official deprecation for > the "reserved" Query Parameters used by Traffic Router > > Is there someone out there using query parameters like e.g. `format` and > `fakeClientIPAddress` who would for some reason be unable to use HTTP Headers > instead? > ________________________________________ > From: Dan Kirkwood <[email protected]> > Sent: Monday, May 6, 2019 4:54 PM > To: [email protected] > Subject: [EXTERNAL] new feature: Consistent Hash with Query Parameters > > Hi all.. I've just submitted a PR as a draft - > https://github.com/apache/trafficcontrol/pull/3552 that adds a new field to > a deliveryservice. `consistentHashQueryParams` lists the query parameter > keys that may be used on a deliveryservice to be included in addition to > the url path when the consistent hash value is calculated. This would > allow, for example, the same path to be used for an asset in a different > format, but not require the same cache to be used for each. > > I submitted as a draft for now to allow testing on it. Right now, the db, > traffic ops, and traffic router changes are included. Traffic portal > changes are to follow. > > Comment welcome.. > > Dan
