Agreed, weasel has been working quite well. At one point, though, we were part of a group that had CI reporting the rat results up to a larger group inside Apache, which collated the results and displayed charts of compliance. If we're still doing that, we might need to disable that as well so it doesn't show up incorrectly there.
On Wed, May 8, 2019 at 10:01 AM Eric Friedrich -X (efriedri - TRITON UK BIDCO LIMITED c/o Alter Domus (UK) Limited -OBO at Cisco) <[email protected]> wrote: > > Im good to disable RAT > > > On May 8, 2019, at 11:57 AM, Dan Kirkwood <[email protected]> wrote: > > > > we currently have rat and weasel both scanning for inappropriate/incomplete > > license info. weasel has been catching issues pretty well, and both require > > some intervention to skip files without an Apache header (vendored files, > > mostly), so requires changes in 2 places. > > > > `weasel` runs as part of the standard `master` and `PR` build. `rat` runs > > as separate jobs in Jenkins. > > > > Anyone have an objection to disabling rat jobs at this point and just > > sticking with weasel? > > > > Just looking for a simple yes or no… > > > > thanks.. Dan > > > > Files with unapproved licenses: > > > > > > apache-trafficcontrol-3.0.0/traffic_portal/app/src/assets/css/jsonformatter.min_0.6.0.css > > > > apache-trafficcontrol-3.0.0/traffic_portal/app/src/assets/js/fast-json-patch_v2.1.0.js > > > > apache-trafficcontrol-3.0.0/traffic_portal/app/src/assets/js/jsonformatter.min_0.6.0.js > > > > ***************************************************** > > + exit 1 >
