Thanks Rawlin! On Fri, May 31, 2019 at 3:24 PM Rawlin Peters <rawlin.pet...@gmail.com> wrote:
> That is a good point. In this case, artificially rate-limiting our > high-risk PRs into master is making it harder to contribute and > collaborate, and I don't really want to hold up that PR when Eric is > chomping at the bit to add onto it :). I'll go ahead and merge it. > > - Rawlin > > On Fri, May 31, 2019 at 3:10 PM Dave Neuman <neu...@apache.org> wrote: > > > > As far as I know we haven't yet defined our next release so I don't see > why > > we are trying to rate limit the PRs we merge. I don't remember us > > providing any guarantees that master will be stable and production ready. > > That is why we have a release process. > > Rawlin if you are uncomfortable merging it, let me know and I will be > happy > > to merge. > > Thanks, > > Dave > > > > On Fri, May 31, 2019 at 2:27 PM Rawlin Peters <rawlin.pet...@gmail.com> > > wrote: > > > > > I've been holding off on merging that one just because it's a > > > high-risk change, and we're kind of trying to space out the merging of > > > high-risk PRs into master. That being said, I'm hoping to merge this > > > one within a week or two, but that PR should be stable enough that you > > > could checkout Rob's PR branch and start making your changes against > > > that. Once Rob's PR is merged you should be able to rebase your > > > changes on master. > > > > > > - Rawlin > > > > > > On Fri, May 31, 2019 at 2:02 PM Fieck, Brennan > > > <brennan_fi...@comcast.com> wrote: > > > > > > > > Willing? Absolutely. Able? Not at all. > > > > ________________________________________ > > > > From: Eric Friedrich -X (efriedri - TRITON UK BIDCO LIMITED c/o Alter > > > Domus (UK) Limited -OBO at Cisco) <efrie...@cisco.com.INVALID> > > > > Sent: Friday, May 31, 2019 1:33 PM > > > > To: dev@trafficcontrol.apache.org > > > > Subject: [EXTERNAL] PR3075 - Merging parent.config in > traffic_ops_golang > > > > > > > > Hey All- > > > > Looks like we are ready to get #3075 into master. I have some Cache > > > Assignment Group related changes I would like to make to parent.config > and > > > would prefer to do them in Go. > > > > > > > > I’m waiting for this PR to get merged before I can proceed: > > > > > > > > https://protect2.fireeye.com/url?k=de93c7ac-8277c967-de93e018-000babff3540-17ef99cd013478a2&u=https://github.com/apache/trafficcontrol/pull/3075 > > > > > > > > > > > > Looks like there are no objections in the review and all of the tests > > > pass. > > > > > > > > Would one of the reviewers be willing to hit the merge button? > > > > > > > > Thanks, > > > > Eric > > > > > > > >
