Oh, okay. Forgot to downgrade my Go before testing. I retract my -1 On Tue, Oct 29, 2019 at 12:26 PM Rawlin Peters <[email protected]> wrote:
> @ocket8888 the unit tests pass when using Go 1.9.4, which is what the > 3.1 release builds with. I just verified this (as well as the unit > tests in traffic_monitor, traffic_stats, and lib). > > I'll give it a +1. > > - Rawlin > > On Tue, Oct 29, 2019 at 11:59 AM ocket 8888 <[email protected]> wrote: > > > > -1, unit tests don't pass: build failures > > > > # > > > github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice/servers > > deliveryservice/servers/servers.go:273: Errorln call has possible > > formatting directive %v > > FAIL > > > github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice/servers > > [build failed] > > # github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/origin > > origin/origins_test.go:126: Debugln call has possible formatting > directive > > %v > > FAIL > github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/origin > > [build failed] > > # github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/server > > server/servers_test.go:167: Debugln call has possible formatting > directive > > %v > > FAIL > github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/server > > [build failed] > > > > On Tue, Oct 29, 2019 at 9:31 AM <[email protected]> wrote: > > > > > Still need one more +1. Any takers? > > > > > > > On Sep 6, 2019, at 4:43 PM, [email protected] wrote: > > > > > > > > Hello All, > > > > > > > > I've prepared a release for v3.1.0-RC1 > > > > > > > > The vote is open for at least 72 hours and passes if a majority of at > > > least 3 +1 PMC votes are cast. > > > > > > > > [ ] +1 Approve the release > > > > > > > > [ ] -1 Do not release this package because ... > > > > > > > > Changes since 3.0.2: > > > > > > > > https://github.com/apache/trafficcontrol/compare/RELEASE-3.0.2...RELEASE-3.1.0-RC1 > > > > > > > > This corresponds to git: > > > > Hash: ed8fe3a09 > > > > Tag: RELEASE-3.1.0-RC1 > > > > > > > > Which can be verified with the following: git tag -v > RELEASE-3.1.0-RC1 > > > > > > > > My code signing key is available here: > > > > http://keys.gnupg.net/pks/lookup?search=0x05BE71D9&op=vindex > > > > > > > > Make sure you refresh from a key server to get all relevant > signatures. > > > > > > > > The source .tgz file, pgp signature (.asc signed with my key from > > > > above), and sha512 checksums are provided here: > > > > > > > > https://dist.apache.org/repos/dist/dev/trafficcontrol/3.1.0/RC1/ > > > > > > > > > > > > Thanks! > > > > Derek Gelinas > > > > [email protected] > > > > > > >
