+1 on deprecating it. We should validate that the route is actually complete before removing the `-wip` part, because that usually means a rewritten route is incomplete.
- Rawlin On Fri, Nov 22, 2019 at 10:09 AM ocket 8888 <[email protected]> wrote: > > Actually, as Jeremy pointed out on that issue, all that needs to be done is > rename the existing, undocumented `/hwinfo-wip` route. So I'm not really > rewriting it, just adding a deprecation notice. > > On Fri, Nov 22, 2019 at 9:44 AM ocket 8888 <[email protected]> wrote: > > > The /hwinfo endpoint doesn't appear to serve any real purpose (anymore?). > > There's no way to insert data through the API so it can only even show > > anything if the database is manually manipulated. > > > > This is not to be confused with /hwinfo/dtdata, which I believe we already > > agreed to deprecate (?). > > > > There's currently a deprecation notice in the documentation, but not in > > the API - and that deprecation was never brought up here. So is there > > anyone that objects to making this deprecation official? I'm already > > working on a rewrite to Go, so I can add the API deprecation warning at the > > same time. > >
