+1 > it results in a race condition between the two, as the resulting RPMs have the same filename
That used to happen, but it was fixed in 556ccf. But still, +1 on renaming and making the Golang TM the default. On Fri, Jul 14, 2017 at 11:00 AM, Jeff Elsloo <els...@apache.org> wrote: > Hi all, > > We currently have two versions of Traffic Monitor: Java and golang. > When we build all components, as far as I know, it results in a race > condition between the two, as the resulting RPMs have the same > filename. A PR[1] was opened to address the issue and the approach was > to add `_go` to the version string used for the golang version's RPM. > > Rob and I both think we (Comcast) have enough experience running the > golang version that we have identified and corrected any major issues > and that it is stable enough to be the preferred Traffic Monitor hence > forth. > > Therefore, I propose that within the project's directory structure, we: > 1) rename traffic_monitor to traffic_monitor_legacy > 2) rename traffic_monitor_golang to traffic_monitor > > ..then work with the person that submitted the PR to take the same > approach, except change the Java version's RPM name to contain > `_legacy`. > > I realize that this is a fairly significant change, the type that we > typically reserve for major releases. The next major release, 3.0.0, > is likely to be some time out in the future, and I don't know that we > need to wait for it in order to make this change. > > How does the group feel about the above proposal, and executing on it > prior to the 3.0.0 release (i.e.: for 2.1.0)? Then, when we do > actually prepare the 3.0.0 release, we can remove the Java version > from the codebase entirely. Obviously this could impact anyone that > has automated CI systems building components, in addition to the > Apache CI we use ourselves. > > Thoughts? > > [1] https://github.com/apache/incubator-trafficcontrol/pull/731 > -- > Thanks, > Jeff >
