[
https://issues.apache.org/jira/browse/TS-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790386#action_12790386
]
Leif Hedstrom commented on TS-52:
---------------------------------
A few comments (these similar to the comments in TS-6):
In this patch, you do
+static char local_state_dir[PATH_MAX];
which I think is good, but inconsistent with your TS-6 patch.
This comment should be changed, to reflect that the "root" dir is whatever
--prefix was specified, or /usr/local:
+ if (stat(log_dir, &stat_buf) < 0) {
+ // Try 'root_dir/var/log/trafficserver' directory
+ snprintf(log_dir, sizeof(log_dir), "%s%s%s%s%s%s%s",
+ root_dir, DIR_SEP,"var",DIR_SEP,"log",DIR_SEP,"trafficserver");
For this:
- if ((env_path = getenv("ROOT")) || (env_path = getenv("INST_ROOT"))) {
+ if ((env_path = getenv("ATS_ROOT")) || (env_path = getenv("ATS_INST_ROOT")))
{
Just as in TS-6, lets standardize on one environment variable only, $TS_ROOT.
This error message should be fixed accordingly:
+ cop_log(COP_FATAL," please set correct path in either env variable
ATS_ROOT or in /etc/traffic_server \n");
Lets make sure we use TS_ROOT consistently through the code, and
$prefix/{etc,var}/trafficserver as the defaults.
> traffic_cop does not start
> --------------------------
>
> Key: TS-52
> URL: https://issues.apache.org/jira/browse/TS-52
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.0a
> Environment: All linux
> Reporter: George Paul
> Attachments: TS-52_traffic_cop_patch1.diff,
> TS-52_traffic_cop_patch2.diff
>
>
> Currently Traffic Cop does not start and will not bring up Traffic Manager &
> Traffic Server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
