[
https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831075#action_12831075
]
Leif Hedstrom commented on TS-130:
----------------------------------
Alright, I'll do another review with the new diffs :).
The reason I asked about DDebug() was because it was used in the v2 patch, but
I couldn't see it defined anywhere.
Finally, +1 on the proposal to Diag(). I'd like to add to that that it'd be
really great if we came up with a better, well organized "tree" of tags for the
diagnostics messages. Right now, it's a crapshoot what you will get when
tracing on say '.*http.*'.
> we should generate a config.h file instead of putting all the -Ds in the
> CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
> Attachments: config.h-jp-v1.patch, ts-config.h-jp-v2.patch
>
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
