hmm, I have put him in the author of git commit:
commit 6dadea4cea3da45e432dc52c7f9dadbf891b510a
Author: Craig Forbes <[email protected]>
Date: Fri Nov 9 00:44:52 2012 +0800
TS-1564: Logs created via the API in plugins are not rolled
should we strict on the style? which one is prefer then?
在 2012-11-09五的 00:01 +0000，Igor Galić写道：
> > diff --git a/CHANGES b/CHANGES
> > index 106ef3c..8a620a1 100644
> > --- a/CHANGES
> > +++ b/CHANGES
> > @@ -1,6 +1,8 @@
> > -*- coding:
> > utf-8 -*-
> > Changes with Apache Traffic Server 3.3.1
> >
> > + *) [TS-1564] fix the rolling of Logs created via the API in
> > plugins
> > +
>
> This is missing the crediting of the original author.
>
> > *) [TS-1565] TSStringPercentEncode returns one character short in
> > no-op case
> > (no encoding needed). Author: Thach Tran <tranngocthachs at
> > gmail dot com>.
> >
> >
> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/6dadea4c/proxy/logging/LogObject.h
> > ----------------------------------------------------------------------
> > diff --git a/proxy/logging/LogObject.h b/proxy/logging/LogObject.h
> > index b163696..141afa1 100644
> > --- a/proxy/logging/LogObject.h
> > +++ b/proxy/logging/LogObject.h
> > @@ -384,6 +384,9 @@ inline int LogObjectManager::roll_files(long
> > time_now)
> > for (size_t i=0; i < _numObjects; i++) {
> > num_rolled += _objects[i]->roll_files(time_now);
> > }
> > + for (size_t i=0; i < _numAPIobjects; i++) {
> > + num_rolled += _APIobjects[i]->roll_files(time_now);
> > + }
> > return num_rolled;
> > };
> >
> >
> >
>
> i
>
