On Oct 17, 2013, at 6:21 AM, Igor Galić <[email protected]> wrote:
> > > ----- Original Message ----- >> Updated Branches: >> refs/heads/master 0d886aabb -> a263d384d >> >> >> small change to make eclipse happy >> >> >> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo >> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a263d384 >> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a263d384 >> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a263d384 >> >> Branch: refs/heads/master >> Commit: a263d384d4f70ddc65d9c0ee21950ef2f4c79d0e >> Parents: 0d886aa >> Author: Zhao Yongming <[email protected]> >> Authored: Thu Oct 17 17:52:58 2013 +0800 >> Committer: Zhao Yongming <[email protected]> >> Committed: Thu Oct 17 17:52:58 2013 +0800 >> >> ---------------------------------------------------------------------- >> iocore/eventsystem/I_EventProcessor.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> ---------------------------------------------------------------------- >> >> >> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a263d384/iocore/eventsystem/I_EventProcessor.h >> ---------------------------------------------------------------------- >> diff --git a/iocore/eventsystem/I_EventProcessor.h >> b/iocore/eventsystem/I_EventProcessor.h >> index 40d8e94..2820e9b 100644 >> --- a/iocore/eventsystem/I_EventProcessor.h >> +++ b/iocore/eventsystem/I_EventProcessor.h >> @@ -112,7 +112,7 @@ public: >> @return event object representing the start of the thread. >> >> */ >> - Event *spawn_thread(Continuation * cont, const char *thr_name, size_t >> stacksize, ink_sem * sem = NULL); >> + Event *spawn_thread(Continuation * cont, const char *thr_name, size_t >> stacksize = 0, ink_sem * sem = NULL); > > rather than 0, shouldn't we set this to our preferred stacksize then? > Or does that happen within spawn_threat if stacksize == 0? I think that this is safe, because it ultimately calls ink_thread_create(), which doesn't set the stack size if it is passed 0. This is worth a code comment, however. I'm also curious what it was that Eclipse didn't like. J
