----- Original Message ----- > 20 hours ago, Weijin pushed out our first effort of forward porting our > cluster refine codes, in this big fat patch, we have refined the cluster
First of all I want to say a big thanks for this gigantic effort. Those results look truly impressive. I do however have some criticism as to how it has been delievered: I think it would have been better in a series of patches that show the evolution. Also, better comments and commit messages explaining the specific changes that went into each bigger change. That way we can also split the over-arching change into multiple Jira tickets. We did this for TS-2281 (Augment config system to use LUA). A patch this big makes it a lot harder for anyone reviewing the code. As such, we have to fallback to asking silly questions on the Mailing List ;) > communication in the message level, to archive better performance. > > what we do: > • make cluster a pure message driven layer, no more vc splice on each side What message protocol are we using here? > • cleanup the msg encapsulation and callback implements > • modified the cache cluster interface Does this touch the Cache APIs or the internal Cache on-disk layout? i.e.: What does it mean to people who do not use the cluster? > due to the big change we made, there is something we changed in the cluster: > * load monitor Can this be "abstracted" into an API that load-balancer plugins could use? > * hostdb cluster interface > as our main platform is Linux, and due to the network codes we can not reuse, With small patches going into the branch, this is something other contributors interested in those platforms could have helped with. > we have made some dirty codes into the new cluster, that will need more work > to get clean, to make it multi-platform aware and clean. With small patches going into the branch, this is something reviewers could have caught in the process, as the design's implementation unfolds. > anyway, it is out, please join us on the hacking and testing. > > those codes performs >4G/box traffic in our network, and there is no limit in > cluster performance anymore > > please refer to the codes and wiki: > codes in: > https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;a=shortlog;h=refs/heads/refine_cluster > wiki at: > https://cwiki.apache.org/confluence/display/TS/Clustering > jira at: > https://issues.apache.org/jira/browse/TS-2005 > > the patch is a joint effort of WeiJin and YuQing > thanks -- Igor Galić Tel: +43 (0) 664 886 22 883 Mail: [email protected] URL: http://brainsware.org/ GPG: 8716 7A9F 989B ABD5 100F 4008 F266 55D6 2998 1641
