Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/280#issuecomment-134649058
This branch needs to be cleaned up before it can be merged. Please rebase
the patches so that there is:
- a patch that adds CacheProcessor::cacheRequired() with no other change
of behavior
- other no-op patches that don't change behaviour
- a single patch that implements the desires behavior.
You need to add comments. Commit comments explaining what each patch in
doing and why. Code comments.
Please run ```clang-format``` on the patches. Squash and remove patches
that fix bugs in earlier patches. Follow existing coding style (eg. we don't
use Hungarian notation).
The documentation of ```proxy.config.http.cache.required``` seems
inaccurate. The 0 value conflicts with ```wait_for_cache```, so you should
explain how that interacts. Is there any code here that actually stops serving
if we lose a disk?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
