Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/304#issuecomment-146912485
For example, ```RecLookupMatchingRecords``` doesn't lock around
```g_records```, likewise ```g_records``` is not locked anywhere in
```P_RecCore.cc```. The ```g_records_rwlock``` lock seems to be used when
accessing the records store via the hash table, so it is not clear to me why
you need to lock here.
In the stack trace, the relevant record is of type ```RECD_INT``` but by
the time it gets to the plugin it is ```RECD_STRING```. The
```proxy.process.ssl.origin_server_decryption_failed``` metric is a
```RECD_INT```, so how did it get a partial update to a different type? Rather
than adding extra locking, I really want an explanation of why the global lock
should be held here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
