Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/320#discussion_r43909560
  
    --- Diff: proxy/shared/DiagsConfig.cc ---
    @@ -281,7 +281,8 @@ DiagsConfig::DiagsConfig(const char *filename, const 
char *tags, const char *act
       ////////////////////////////////////////////////////////////////////
     
       if (!use_records) {
    -    diags = new Diags(tags, actions, NULL);
    +    diags_log = NULL;
    --- End diff --
    
    Allright, I see James' comment now. Based on that and the Coverity report I 
think the best option is to move that to a member initializer at the top of the 
constructor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to