Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/362#discussion_r46780770
--- Diff: proxy/http2/HPACK.cc ---
@@ -332,18 +332,41 @@ int64_t
encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char
*value, size_t value_len)
{
uint8_t *p = buf_start;
+ bool use_huffman = true;
--- End diff --
According to [Compression
Ratio](https://github.com/http2jp/hpack-test-case/wiki/Compression-Ratio) in
[hpack-test-case](https://github.com/http2jp/hpack-test-case), the best
compression rate is `0.31` but compression rate of naive-huffman imprementation
(I guess this is similar to this PR) is `0.85`. So we have to back to here and
implement smart algorithm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
