Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/359#issuecomment-162602947
Hi James,
I've squashed several commits and cleaned up the history, I'll be more
descriptive in the future. Also, I found that I had left in some code for the
multi-site origin feature. I've removed this code and the branch only includes
the refactor for the secondary hash ring and it's regression tests. All
re-testing in my QA environment and regression tests are good.
Thanks
--
John J. Rushford
IPCDN Engineering
1400 Wewatta Street, Denver Colorado 80202
[email protected]
From: James Peach
<[email protected]<mailto:[email protected]>>
Reply-To: apache/trafficserver
<[email protected]<mailto:[email protected]>>
Date: Sunday, December 6, 2015 at 5:31 PM
To: apache/trafficserver
<[email protected]<mailto:[email protected]>>
Cc: John Rushford
<[email protected]<mailto:[email protected]>>
Subject: Re: [trafficserver] TS-3418: Second hash ring for consistently
hashed parent selection (#359)
Hi John. First, let's clean up the commit history on this branch.
* please squash the "clang format" and "updated comments" commits into
their respective previous commits.
* for each commit, the subject should be a short description like
TS-3418: what this commit does"
* for each commit, add a longer description in the commit message for
future generations. What are all the changes in this commit? Why are they
necessary? Try to include enough description for someone to understand what is
going on in the commit.
-
Reply to this email directly or view it on
GitHub<https://github.com/apache/trafficserver/pull/359#issuecomment-162380212>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
