Github user shaygalon commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-203657654
For the 64K page size, a multiple of kernel page size would be fine and
more future proof. It would be better to have it as a variable and not a
constant, and assign sysconf(_SC_PAGESIZE). However, I was trying to minimize
impact of changes. 64K is of particular interest as that is the default page
size for arm64 kernels for redhat/centos/fedora etc.
For locking - absolutely, again I was trying to minimize impact, and not
add more dependencies. Since this is highly platform dependent and only affects
performance and not correctness, left it wrapped in a macro. Perhaps you would
like to add a configure test that will check the timing for a variety of
locking mechanisms, and choose the best one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
