Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/556#issuecomment-207522902
Looks good to me. However can we use namespaces? I mean
ts_stl_iobuf_allocator!!
it would better in my view to have
namespace ts{
template <...>
class iobuf_allocator{
}
}
vs having really_long_class_names_that_have_namespaces_built_into_them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---