GitHub user pbchou opened a pull request:
https://github.com/apache/trafficserver/pull/571
TS-3245 : Changes optind = 1 to optind = 0 for all plugins to ensure
that multiples plugins in the global plugin.config can co-exist
together. Note that all plugins were already optind = 0 except
for the four that were modified in the this commit
(background_fetch,
regex_revalidate, remap_stats, and stale_while_revalidate).
Note: This patch does NOT change ATS core so that future plugins
must be sure to use optind = 0 also.
Understood preference is for ATS core change to cover all plugins, but this
has been outstanding for more than one year and affects our usage of ATS. Also,
I am not sure if an ATS core change can cover the plugins since according to
the Linux man page setting optind=0 and calling getopt_long() causes an
"internal" initialization process to run which looks at the optstring argument
to getopt_long(). ATS core would not have pre-knowledge of each plugin's
internals so this seems like this would be a road-block?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pbchou/trafficserver TS-3245
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/571.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #571
----
commit a5141b2a90206d439841e1bd96aa5e8b15bcc9dd
Author: Peter Chou <[email protected]>
Date: 2016-04-12T18:34:01Z
TS-3245 : Changes optind = 1 to optind = 0 for all plugins to ensure
that multiples plugins in the global plugin.config can co-exist
together. Note that all plugins were already optind = 0 except
for the four that were modified in the this commit
(background_fetch,
regex_revalidate, remap_stats, and stale_while_revalidate).
Note: This patch does NOT change ATS core so that future plugins
must be sure to use optind = 0 also.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
