Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/554#issuecomment-214621535
Well, I'm not sure that I agree it violates the encapsulation-- since its
effectively a variable that tracks timings (which are only set in specific
states in the state machine-- IIRC most are only set once) which makes it more
or less a history of where the HTTPSM has gone. For this particular feature I
need to know "have we sent bytes" and today the only way that is stored is in
the milestones. It sounds like both of you guys ( @zwoop and @jpeach ) want me
to add a bool to the state machine to store this-- which I can do, but since
the milestone is only set in one place, it'll effectively be the same check--
so i still don't really get how that would be "cleaner" in any way :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
