Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/635#issuecomment-219307477
I'm not sure I understand the full intent of this patch. It looks like it's
always adding the Client-IP header, even if not enabled in records.config? Why
is this necessary?
I understand that the $i here uses the value from the Client-IP, which
again doesn't make a lot of sense. Why not just move out the logic that gets
the client-ip (TSHttpTxnClientAddrGet), and use that in the
RemapRegex::substitute()? I.e. why does it use the Client-IP header here at all?
Alternatively, maybe one of
1) Honor the request Client-IP in RemapRegex::substitute() if set.
2) Or add another directive,%I, which uses the Client-IP
But, in either case, I don't feel that the regex_remap plugin should set
the Client-IP request header as done here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
