Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/642#issuecomment-219751045
My point would be the need to carefully explain what the methods do in
different contexts is the problem. "Local" and "remote" are always clear and
need little explanation and correspond much more to what is wanted - that is,
the ATS address for the connection or the address of the other end of the
connection. If get_server_addr() and get_client_addr() depend in context
sensitive ways on get_local and get_remove, the simplest solution would seem to
be to just remove get_server_addr() and get_client_addr() and directly call the
underlying methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
