GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/651
TS-4458: disabling configuration modification breaks reloading
If you set ``proxy.config.disable_configuration_modification`` to 1,
records configuration callbacks are never registered, so if you update
records.config and then reload with ``traffic_ctl config reload``, the new
configuration is not actually applied.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4458
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/651.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #651
----
commit 244fb89e25df8db550d119f52e04a4d4c960e34f
Author: James Peach <[email protected]>
Date: 2016-05-18T22:47:21Z
TS-4458: Return RecErrT from Rec APIs.
commit 733e0be79507dc8631026378d8975b50dac607fd
Author: James Peach <[email protected]>
Date: 2016-05-19T18:07:12Z
TS-4458: Fix disabled modification behaviour.
If you set proxy.config.disable_configuration_modification to 1 to
prevent writing to records.config, various other features broke.
For example, configuration change callbacks were never run, so
reloading configuration did nothing.
This change retains the callbacks and just disables the persistence
of changes to records.config. Note that if you change a record with
the API, you still have to touch records.config to reload the old
values.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
